New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the ec2.py inventory script to set ansible_host as well as ansible_ssh_host #17113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jlaska can you think of any issues this would cause on the Tower side? |
ansibot
added
affects_2.3
This issue/PR affects Ansible v2.3
bugfix_pullrequest
aws
cloud
labels
Dec 13, 2016
ansibot
added
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Dec 16, 2016
ansibot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Jan 2, 2017
At this point in time I wonder if we should just replace ansible_ssh_host with ansible_host rather than add it alongside. |
jbscare
force-pushed
the
inventory-ec2-py-ansible-host
branch
2 times, most recently
from
March 29, 2017 23:31
5852a6a
to
224afd8
Compare
@willthames : Sure, I've updated the PR to reflect that. |
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Apr 11, 2017
ansibot
added
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
labels
Jun 24, 2017
@jbscare I can't push commits to your branch to rebase this. Would you mind doing so? This looks good to me. |
jbscare
force-pushed
the
inventory-ec2-py-ansible-host
branch
from
July 17, 2017 14:52
224afd8
to
f68506e
Compare
Sure thing; done! |
ansibot
removed
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Jul 17, 2017
ryansb
approved these changes
Jul 17, 2017
ansibot
added
feature
This issue/PR relates to a feature request.
bug
This issue/PR relates to a bug.
and removed
feature_pull_request
labels
Mar 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.3
This issue/PR affects Ansible v2.3
aws
bug
This issue/PR relates to a bug.
c:inventory/contrib_script
cloud
feature
This issue/PR relates to a feature request.
inventory
Inventory category
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT NAME
contrib/inventory/ec2.py
ANSIBLE VERSION
SUMMARY
contrib/inventory/ec2.py sets ansible_ssh_host, but http://docs.ansible.com/ansible/intro_inventory.html#hosts-and-groups says
Since the ansible_ssh_* variables aren't removed, just deprecated, this commit simply adds ansible_host to the variables set by ec2.py.
May address some (but probably not all) of #15286.