Set PRIVILEGED=true for non_destructive tests. #17733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow test_mount tests to run on Shippable.
mattclay
added a commit
to mattclay/ansible
that referenced
this pull request
Sep 24, 2016
This reverts commit 1384270.
mattclay
added a commit
that referenced
this pull request
Sep 24, 2016
abadger
added a commit
to abadger/ansible
that referenced
this pull request
Sep 26, 2016
Revert "Revert "Set PRIVILEGED=true for non_destructive tests. (ansible#17733)" (ansible#17738)" This reverts commit dc0fb1c.
abadger
added a commit
to abadger/ansible
that referenced
this pull request
Sep 28, 2016
Revert "Revert "Set PRIVILEGED=true for non_destructive tests. (ansible#17733)" (ansible#17738)" This reverts commit dc0fb1c.
abadger
added a commit
that referenced
this pull request
Sep 28, 2016
* Turn mount test back on * Mount tests need PRIVILEGED so turn that back on Revert "Revert "Set PRIVILEGED=true for non_destructive tests. (#17733)" (#17738)" This reverts commit dc0fb1c. * Add a needs_privileged tag so that we can skip mount tests on centos6 Some containers timeout on shippable tests when run with privileged. Unfortunately, some tests require that in order to run. Tagging those allows us to skip those tests on the platforms that timeout when we get ready to run the integration test in shippable. * Centos6 times out with PRIVILEGED set so remove that (will disable the mount tests on centos6) * Remove false start
sereinity
pushed a commit
to sereinity-forks/ansible
that referenced
this pull request
Jan 25, 2017
This should allow test_mount tests to run on Shippable.
sereinity
pushed a commit
to sereinity-forks/ansible
that referenced
this pull request
Jan 25, 2017
…" (ansible#17738) This reverts commit 1384270.
sereinity
pushed a commit
to sereinity-forks/ansible
that referenced
this pull request
Jan 25, 2017
* Turn mount test back on * Mount tests need PRIVILEGED so turn that back on Revert "Revert "Set PRIVILEGED=true for non_destructive tests. (ansible#17733)" (ansible#17738)" This reverts commit dc0fb1c. * Add a needs_privileged tag so that we can skip mount tests on centos6 Some containers timeout on shippable tests when run with privileged. Unfortunately, some tests require that in order to run. Tagging those allows us to skip those tests on the platforms that timeout when we get ready to run the integration test in shippable. * Centos6 times out with PRIVILEGED set so remove that (will disable the mount tests on centos6) * Remove false start
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
shippable.yml
ANSIBLE VERSION
SUMMARY
Set PRIVILEGED=true for non_destructive tests.
This should allow test_mount tests to run on Shippable.