Add support for group variables to handlers

[byrondover]

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

Ansible Core

ANSIBLE VERSION

ansible 2.3.0 (devel 0a86ddc251) last updated 2016/10/05 13:51:38 (GMT +200)
  lib/ansible/modules/core: (detached HEAD 0ee774ff15) last updated 2016/10/05 13:51:46 (GMT +200)
  lib/ansible/modules/extras: (detached HEAD 5cc72c3f06) last updated 2016/10/05 13:51:53 (GMT +200)
  config file = 
  configured module search path = Default w/o overrides

SUMMARY

Fixes #15103.

Moves variables['groups'] assignment from if hosts: scope to if self._inventory: scope, to better support task delegation within handlers (e.g. using with_items or with_inventory_hostnames).

Example role and bug fix illustrated below.

% cat development

[webservers]
master1.foobarsites.com

[slaves]
slave1.foobarsites.com
slave2.foobarsites.com
slave2.foobarsites.com

% cat roles/test_role/tasks/main.yml

- name: Trigger handlers.
  command: true
  notify: test_handler

% cat roles/test_role/handlers/main.yml

- name: test_handler
  command: true
  delegate_to: "{{ item }}"
  with_inventory_hostnames: slaves

Before [Doesn't Work]

% ansible-playbook -i hosts/dev site.yml

PLAYBOOK: test.yml *************************************************************
1 plays in test.yml

PLAY [webservers] **************************************************************

TASK [test_role : Trigger handlers.] *******************************************

ERROR! Unexpected Exception: 'groups'
the full traceback was:

Traceback (most recent call last):
  File "/usr/local/bin/ansible-playbook", line 92, in <module>
    exit_code = cli.run()
  File "/usr/local/Cellar/ansible/2.1.2.0/libexec/lib/python2.7/site-packages/ansible/cli/playbook.py", line 154, in run
    results = pbex.run()
  File "/usr/local/Cellar/ansible/2.1.2.0/libexec/lib/python2.7/site-packages/ansible/executor/playbook_executor.py", line 146, in run
    result = self._tqm.run(play=play)
  File "/usr/local/Cellar/ansible/2.1.2.0/libexec/lib/python2.7/site-packages/ansible/executor/task_queue_manager.py", line 264, in run
    play_return = strategy.run(iterator, play_context)
  File "/usr/local/Cellar/ansible/2.1.2.0/libexec/lib/python2.7/site-packages/ansible/plugins/strategy/linear.py", line 271, in run
    results += self._wait_on_pending_results(iterator)
  File "/usr/local/Cellar/ansible/2.1.2.0/libexec/lib/python2.7/site-packages/ansible/plugins/strategy/__init__.py", line 478, in _wait_on_pending_results
    results = self._process_pending_results(iterator)
  File "/usr/local/Cellar/ansible/2.1.2.0/libexec/lib/python2.7/site-packages/ansible/plugins/strategy/__init__.py", line 371, in _process_pending_results
    target_handler = search_handler_blocks(iterator._play.handlers)
  File "/usr/local/Cellar/ansible/2.1.2.0/libexec/lib/python2.7/site-packages/ansible/plugins/strategy/__init__.py", line 326, in search_handler_blocks
    handler_vars = self._variable_manager.get_vars(loader=self._loader, play=iterator._play, task=handler_task)
  File "/usr/local/Cellar/ansible/2.1.2.0/libexec/lib/python2.7/site-packages/ansible/vars/__init__.py", line 379, in get_vars
    all_vars['ansible_delegated_vars'] = self._get_delegated_vars(loader, play, task, all_vars)
  File "/usr/local/Cellar/ansible/2.1.2.0/libexec/lib/python2.7/site-packages/ansible/vars/__init__.py", line 456, in _get_delegated_vars
    items = lookup_loader.get(task.loop, loader=loader, templar=templar).run(terms=loop_terms, variables=vars_copy)
  File "/usr/local/Cellar/ansible/2.1.2.0/libexec/lib/python2.7/site-packages/ansible/plugins/lookup/inventory_hostnames.py", line 49, in run
    that = self.get_hosts(variables, p)
  File "/usr/local/Cellar/ansible/2.1.2.0/libexec/lib/python2.7/site-packages/ansible/plugins/lookup/inventory_hostnames.py", line 35, in get_hosts
    if obj in variables['groups']:
KeyError: 'groups'

After [Works as Expected]

% ansible-playbook -i hosts/dev site.yml

PLAYBOOK: test.yml *************************************************************
1 plays in test.yml

PLAY [webservers] **************************************************************

TASK [test_role : Trigger handlers.] *******************************************
changed: [localhost.foobarsites.com]

RUNNING HANDLER [test_role : test_handler] *************************************
changed: [master1.foobarsites.com -> slave1.foobarsites.com] => (item=slave1.foobarsites.com)
changed: [master1.foobarsites.com -> slave2.foobarsites.com] => (item=slave2.foobarsites.com)
changed: [master1.foobarsites.com -> slave3.foobarsites.com] => (item=slave3.foobarsites.com)

PLAY RECAP *********************************************************************
localhost.foobarsites.com  : ok=0    changed=1    unreachable=0    failed=0

[bcoca]

I don't think this is the correct fix, it seems we should not try to compile the full handler until it is time to execute and the variables are available in that context.

cc @jimi-c

[ansibot]

@byrondover This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

[ansibot]

@byrondover This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

[ansibot]

@byrondover You have not responded to information requests in this pullrequest so we will assume it no longer affects you. If you are still interested in this, please create a new pullrequest with the requested information.

click here for bot help