group_vars: host_vars: warn for non-yaml files in dirs

[resmo]

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

host_vars, group_vars

ANSIBLE VERSION

devel, 2.2, 2.1

SUMMARY

fixes #17968
ignore warn for files without a known yaml extension in group_/host_vars if directories like group_vars/group/... are used.

[jhawkesworth]

I don't think the documentation is consistent about using extensions for host_vars / group_vars.
For example here on the best practices page:
http://docs.ansible.com/ansible/playbooks_best_practices.html#variables-and-vaults

This change would mean I would have to change all the files in my group_vars folders.

Perhaps a warning if backup file names, say those containing ~ are found in group vars / host vars would be a practical compromise?

[resmo]

I don't see any conflicts with the best practice guide,"...create two files named vars and vault...", that still works as these files have no extension.

But I would say this commit has some potential to break certain setups. A compromise of adding a warning would be an option of course.

[bjolivot]

bot_status

[ansibot]

waiting_on: ansible
component: None
supported_by: core
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
mergeable_state: clean
shippable_status: success
maintainer_shipits: False
community_shipits: False
ansible_shipits: False
shipit_actors: None

click here for bot help

[bcoca]

this does not seem like the right fix, it seems to compensate for the extension filter being broken, we shoudl fix that instead.