Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bare variable references in docs #18455

Merged
merged 1 commit into from
Nov 10, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docsite/rst/guide_aws.rst
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ From this, we'll use the add_host module to dynamically create a host group cons

- name: Add all instance public IPs to host group
add_host: hostname={{ item.public_ip }} groups=ec2hosts
with_items: ec2.instances
with_items: "{{ ec2.instances }}"

With the host group now created, a second play at the bottom of the the same provisioning playbook file might now have some configuration steps::

Expand Down
2 changes: 1 addition & 1 deletion docsite/rst/guide_cloudstack.rst
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ Now to the fun part. We create a playbook to create our infrastructure we call i
ip_address: "{{ public_ip }}"
port: "{{ item.port }}"
cidr: "{{ item.cidr | default('0.0.0.0/0') }}"
with_items: cs_firewall
with_items: "{{ cs_firewall }}"
when: public_ip is defined

- name: ensure static NATs
Expand Down
4 changes: 2 additions & 2 deletions docsite/rst/guide_gce.rst
Original file line number Diff line number Diff line change
Expand Up @@ -213,11 +213,11 @@ A playbook would looks like this:

- name: Wait for SSH to come up
wait_for: host={{ item.public_ip }} port=22 delay=10 timeout=60
with_items: gce.instance_data
with_items: "{{ gce.instance_data }}"

- name: Add host to groupname
add_host: hostname={{ item.public_ip }} groupname=new_instances
with_items: gce.instance_data
with_items: "{{ gce.instance_data }}"

- name: Manage new instances
hosts: new_instances
Expand Down
8 changes: 4 additions & 4 deletions docsite/rst/guide_rax.rst
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ The rax module returns data about the nodes it creates, like IP addresses, hostn
ansible_host: "{{ item.rax_accessipv4 }}"
ansible_ssh_pass: "{{ item.rax_adminpass }}"
groups: raxhosts
with_items: rax.success
with_items: "{{ rax.success }}"
when: rax.action == 'create'

With the host group now created, the next play in this playbook could now configure servers belonging to the raxhosts group.
Expand Down Expand Up @@ -522,7 +522,7 @@ Build a complete webserver environment with servers, custom networks and load ba
ansible_ssh_pass: "{{ item.rax_adminpass }}"
ansible_user: root
groups: web
with_items: rax.success
with_items: "{{ rax.success }}"
when: rax.action == 'create'

- name: Add servers to Load balancer
Expand All @@ -536,7 +536,7 @@ Build a complete webserver environment with servers, custom networks and load ba
type: primary
wait: yes
region: IAD
with_items: rax.success
with_items: "{{ rax.success }}"
when: rax.action == 'create'

- name: Configure servers
Expand Down Expand Up @@ -608,7 +608,7 @@ Using a Control Machine
ansible_user: root
rax_id: "{{ item.rax_id }}"
groups: web,new_web
with_items: rax.success
with_items: "{{ rax.success }}"
when: rax.action == 'create'

- name: Wait for rackconnect and managed cloud automation to complete
Expand Down
8 changes: 4 additions & 4 deletions docsite/rst/guide_rolling_upgrade.rst
Original file line number Diff line number Diff line change
Expand Up @@ -209,12 +209,12 @@ Here is the next part of the update play::
- name: disable nagios alerts for this host webserver service
nagios: action=disable_alerts host={{ inventory_hostname }} services=webserver
delegate_to: "{{ item }}"
with_items: groups.monitoring
with_items: "{{ groups.monitoring }}"

- name: disable the server in haproxy
shell: echo "disable server myapplb/{{ inventory_hostname }}" | socat stdio /var/lib/haproxy/stats
delegate_to: "{{ item }}"
with_items: groups.lbservers
with_items: "{{ groups.lbservers }}"

The ``pre_tasks`` keyword just lets you list tasks to run before the roles are called. This will make more sense in a minute. If you look at the names of these tasks, you can see that we are disabling Nagios alerts and then removing the webserver that we are currently updating from the HAProxy load balancing pool.

Expand All @@ -235,12 +235,12 @@ Finally, in the ``post_tasks`` section, we reverse the changes to the Nagios con
- name: Enable the server in haproxy
shell: echo "enable server myapplb/{{ inventory_hostname }}" | socat stdio /var/lib/haproxy/stats
delegate_to: "{{ item }}"
with_items: groups.lbservers
with_items: "{{ groups.lbservers }}"

- name: re-enable nagios alerts
nagios: action=enable_alerts host={{ inventory_hostname }} services=webserver
delegate_to: "{{ item }}"
with_items: groups.monitoring
with_items: "{{ groups.monitoring }}"

Again, if you were using a Netscaler or F5 or Elastic Load Balancer, you would just substitute in the appropriate modules instead.

Expand Down
2 changes: 1 addition & 1 deletion docsite/rst/playbooks_loops.rst
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ One can use a regular ``with_items`` with the ``play_hosts`` or ``groups`` varia

# show all the hosts in the current play
- debug: msg={{ item }}
with_items: play_hosts
with_items: "{{ play_hosts }}"

There is also a specific lookup plugin ``inventory_hostnames`` that can be used like this::

Expand Down