Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the hint to report module issue elsewhere #18820

Merged
merged 1 commit into from Dec 14, 2016
Merged

Remove the hint to report module issue elsewhere #18820

merged 1 commit into from Dec 14, 2016

Conversation

dagwieers
Copy link
Contributor

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

GitHub template

SUMMARY

Remove the hint to report module issue elsewhere.

@dagwieers dagwieers mentioned this pull request Dec 7, 2016
Closed
@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 docs_pull_request labels Dec 13, 2016
@bcoca bcoca added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Dec 13, 2016
@abadger
Copy link
Contributor

abadger commented Dec 13, 2016

@dagwieers I think that a similar change has already been merged. Could you either close or rebase this depending on whether you think the ISSUE_TEMPLATE could use more changes?

@dagwieers
Copy link
Contributor Author

@abadger Thanks for bringing ansibot back ! :-)

It's true that in the meantime someone else made the most important change. So I took the time to see what else could be improved. Let me know what you think.

PS We removed the various "Please ..." statements a year ago and made the instructions more direct. So that's what I did now as well.

@bcoca
Copy link
Member

bcoca commented Dec 14, 2016

i would not use regression, since we don't use the type in our workflow at all I don't see it being useful (its still a bug).

@dagwieers
Copy link
Contributor Author

Sure, I thought it would be useful to prepare a release.
Regressions may be useful to list when doing the next RC.
Also, with regressions you can indicate when it last worked.

I will remove it.

@dagwieers
Copy link
Contributor Author

Please re-review !

@bcoca bcoca merged commit 8a25b24 into ansible:devel Dec 14, 2016
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 3, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.3 This issue/PR affects Ansible v2.3 docs This issue/PR relates to or includes documentation. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dagwieers @abadger @bcoca @ansibot