Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pulp_repo module for interacting with repositories on a pulp server. #18898

Merged
merged 1 commit into from Jan 5, 2017

Conversation

sysadmind
Copy link

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

pulp_repo

ANSIBLE VERSION
ansible 2.2.0.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides

SUMMARY

This adds a module for working with pulp repos. http://www.pulpproject.org/. I added this under packaging/os because it seemed like the most relevant location for this module although it is not explicitly an os packaging module like others in this directory.

I created a class that lines up with a pulp server and added methods for getting and setting repo properties. I chose this design because it closely resembles the actual design of pulp and keeps the code logically separated into small methods.

ok: [L-Pulp101.localdomain]

This is a migration from ansible/ansible-modules-extras#1961

@sysadmind
Copy link
Author

My apologies @Nebelwolf @Nosmoht @dvanallen @jtyr. Seems that I had to move my PR to this repo as the modules have been merged back into core. If you could comment on this PR instead, I would appreciate it. @jtyr I have updated my module after your most recent feedback.

@Nosmoht
Copy link
Contributor

Nosmoht commented Dec 7, 2016

I've tested with the same code as here.

ansible 2.3.0 (pulp f267ed5720) last updated 2016/12/07 22:09:20 (GMT +200)
  config file = /home/tkrah/workspace/vagrant/pulp/ansible.cfg
  configured module search path = Default w/o overrides

Tested to:

  • create repos --check
  • create repos
  • create repos --check
  • remove repos --check
  • remove repos
  • remove repos --check

All steps working fine. Module documentation looks good. Source code looks good too.
Well done @sysadmind.

shipit

@coreaut
Copy link
Contributor

coreaut commented Dec 12, 2016

I tested it with creating and updating repos.
Also with importer_ssl_client_cert and importer_ssl_client_key options.
Everything went fine.

shipit ⛵

@jtyr
Copy link
Contributor

jtyr commented Dec 12, 2016

@sysadmind You probably need to rebase your branch against the current devel branch to allow this to be merged.

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 new_plugin This PR includes a new plugin. labels Dec 13, 2016
@sysadmind
Copy link
Author

Thanks for the heads up @jtyr. These changes should be in line with upstream now.

@ansibot ansibot added module This issue/PR relates to a module. plugin labels Dec 13, 2016
@bcoca bcoca added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Dec 13, 2016
@ansibot ansibot added the shipit This PR is ready to be merged by Core label Dec 13, 2016
@sysadmind
Copy link
Author

@bcoca I'm not sure why this is marked as needs_rebase. I rebased after all of the forced updates and this is a clean PR on top of current devel with a single commit.

@jctanner jctanner removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Dec 13, 2016
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. shipit This PR is ready to be merged by Core and removed shipit This PR is ready to be merged by Core needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 19, 2016
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. shipit This PR is ready to be merged by Core and removed shipit This PR is ready to be merged by Core needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 2, 2017
@jimi-c jimi-c removed the plugin label Jan 4, 2017
@abadger abadger merged commit 337ea4d into ansible:devel Jan 5, 2017
@abadger
Copy link
Contributor

abadger commented Jan 5, 2017

Merged to devel. Thanks !

@sysadmind sysadmind deleted the pulp-repo branch January 5, 2017 14:34
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.3 This issue/PR affects Ansible v2.3 module This issue/PR relates to a module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants