system/service module initctl location usage

[ademmers]

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

lib/ansible/modules/system/service

ANSIBLE VERSION

ansible 2.2.0.0

SUMMARY

Fall back on using initctl command to manage services in preference of start/stop/restart binaries.
Main reason is to use a resolved binary location as service command. Start's location eg is resolved to see if it exists, but the full location is not used to launch the command, as at that point in code not the service command is beeing used but the bare action.

Before:

$ ansible <host>-i <inventory> -sKo -m service -a 'name=<service> state=started enabled=yes'
SUDO password:
<host> | FAILED! => {"changed": false, "cmd": "initctl version", "failed": true, "msg": "[Errno 2] No such file or directory", "rc": 2}

After:

$ ansible <host> -i <inventory> -sKo -m service -a 'name=<service> state=started enabled=yes'
SUDO password:
<host>| SUCCESS => {"changed": false, "enabled": true, "name": "<service>", "state": "started"}

[atosatto]

I confirm that the issue is also affecting ansible 2.2.3 and ansible 2.3.0 on Oracle Linux 6.
I've been able to successfully workaround it with the changes proposed in this PR.

[binhrobles]

In the meantime, I've been manually setting the environment for the task/play and referencing the initctl path like so:

    environment: 
      PATH: '/sbin'

[netsandbox]

@bcoca just hit this bug today in 2.3.3.0.
This PR was tagged affects_2.3 but was never merged in branch stable-2.3, only in stable-2.4.
Any chances to get this in 2.3?