New facts module for AWS VPC Peering

[willthames]

SUMMARY

Retrieves AWS VPC Peering details using AWS methods. Requires Boto3.

• Gets various details related to AWS VPC Peers
  Filters can be found http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeVpcPeeringConnections.html

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ec2_vpc_peering_facts module

ANSIBLE VERSION

2.3

ADDITIONAL INFORMATION

[willthames]

Migrated from ansible/ansible-modules-extras#1431 by willthames (not original author)

[zyv]

Tested on Ansible 2.2, works nicely for me, would be awesome if this could be included upstream! Need such a module to construct routing tables by querying VPC peerings.

[ansibot]

@mmochan @michaeljs1990 @wimnat @erydo @jarv @steynovich @ryansydnor @simplesteph @Java1Guy @rmorlok @pwnall @naslanidis @pjodouin @RickMendes @amir343 @linuxdynasty @timmahoney @tedder @jsdalton @jmenga @tastychutney @scottanderson42 @mjschultz @bpennypacker @zimbatm @brandond @joelthompson @alachaum @TomBamford @jjshoe @j-carl @fiunchinho @Etherdaemon @bekelchik @minichate @MichaelBaydoun @loia @akazakov @Zeekin @silviud @whiter

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

[ryansb]

Otherwise LGTM, just needs to return normalized snake case variables.

[ryansb]

For results, it looks like you're returning the camelcase output from boto3. Can you please use camel_dict_to_snake_dict to normalize the returned values?

[willthames]

Done

[mattclay]

Closing and re-opening to trigger CI.

[mattclay]

CI failure due to module validation failures:

2017-02-03 01:52:35 ============================================================================
2017-02-03 01:52:35 lib/ansible/modules/cloud/amazon/ec2_vpc_peering_facts.py
2017-02-03 01:52:35 ============================================================================
2017-02-03 01:52:35 ERROR: No ANSIBLE_METADATA provided
2017-02-03 01:52:35 ERROR: Import found before documentation variables. All imports must appear below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA. line 17
2017-02-03 01:52:35 ERROR: Import found before documentation variables. All imports must appear below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA. line 20
2017-02-03 01:52:35 ERROR: Import found before documentation variables. All imports must appear below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA. line 21
2017-02-03 01:52:35 ERROR: Import found before documentation variables. All imports must appear below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA. line 22
2017-02-03 01:52:35 ERROR: Import found before documentation variables. All imports must appear below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA. line 23

[zyv]

Just tested the new version with Ansible 2.3 and it works fine for me, just had to adjust playbooks re. snake case / camel case. Looks good to me, a very useful module! Not sure what else I could do to get this merged eventually, too bad it didn't make it into 2.3...

shipit