Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fix for running using Invoke-Expression #20527

Merged
merged 1 commit into from Jan 26, 2017
Merged

Small fix for running using Invoke-Expression #20527

merged 1 commit into from Jan 26, 2017

Conversation

dagwieers
Copy link
Contributor

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ConfigureRemotingForAnsible.ps1

ANSIBLE VERSION

v2.3

SUMMARY

A small fix suggested by a user for running ConfigureRemotingForAnsible.ps1

This fixes #20512

@dagwieers
Small fix for running using Invoke-Expression
b212b41 
A small fix suggested by a user for running ConfigureRemotingForAnsible.

This fixes ansible#20512
@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 bugfix_pull_request needs_triage Needs a first human triage before being processed. windows Windows community labels Jan 20, 2017
@ryansb ryansb added docs_pull_request core_review In order to be merged, this PR must follow the core review workflow. and removed needs_triage Needs a first human triage before being processed. labels Jan 24, 2017
@ansibot ansibot removed the core_review In order to be merged, this PR must follow the core review workflow. label Jan 24, 2017
@dagwieers
Copy link
Contributor Author

@mattclay @trondhindenes @cchurch @mrcrilly @Cryptophobia @nitzmahone @dav1x ready_for_review

@jctanner jctanner mentioned this pull request Jan 25, 2017
Closed
@ansibot ansibot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Jan 25, 2017
@mattclay
Copy link
Member

Closing and re-opening to trigger CI.

@mattclay mattclay closed this Jan 25, 2017
@mattclay mattclay reopened this Jan 25, 2017
@mattclay
Copy link
Member

Apparently closing and re-opening doesn't trigger CI.

@mattclay
Copy link
Member

@dagwieers It seems that Shippable is having trouble with CI for select users, preventing CI from triggering PRs. You're one of the impacted users. I've reported the issue to Shippable. However, until it's fixed, it looks like any PR you open will not have CI.

@mattclay
Copy link
Member

Closing and re-opening to trigger CI.

@mattclay mattclay closed this Jan 26, 2017
@mattclay mattclay reopened this Jan 26, 2017
@mattclay
Copy link
Member

@dagwieers It appears that Shippable has resolved the issue blocking CI for your user.

@ansibot ansibot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Jan 26, 2017
@dagwieers
Copy link
Contributor Author

@mattclay I thought it was a general issue at Shippable, hadn't noticed it was working for others.

@dagwieers
Copy link
Contributor Author

@nitzmahone @gundalow @dav1x @jhawkesworth @jctanner Can we please get this one merged ?

This is a no-brainer.

@mattclay mattclay merged commit e64ef8b into ansible:devel Jan 26, 2017
@ansibot ansibot added docs This issue/PR relates to or includes documentation. bug This issue/PR relates to a bug. and removed docs_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone Awaiting requested review from nitzmahone

Assignees
No one assigned
Labels
affects_2.3 This issue/PR affects Ansible v2.3 bug This issue/PR relates to a bug. docs This issue/PR relates to or includes documentation. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConfigureRemotingForAnsible.ps1 fails when called from github with Invoke-Expression
4 participants
@dagwieers @mattclay @ryansb @ansibot