Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maven_artifact: adding AWS STS session token support #20959

Closed
wants to merge 1 commit into from
Closed

maven_artifact: adding AWS STS session token support #20959

wants to merge 1 commit into from

Conversation

mrcrilly
Copy link

@mrcrilly mrcrilly commented Feb 2, 2017

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

maven_artifect

ANSIBLE VERSION
ansible 2.2.0.0
  config file =
  configured module search path = Default w/o overrides
SUMMARY

Without being able to supply and use the AWS STS session token, AWS STS temporary credentials cannot be used with this module. Without providing the session token, STS users will not be able to download protected artifacts.

This PR fixes the issue by introducing the STS session token, should it be supplied to the module, to the boto3 client at the time of instantiation. It does so without introducing a blank session token to the boto3 client, using an expanded dict, to avoid unknown edge cases with regards to a blank session token.

maven_artifact: adding AWS STS session token support
e09daca 
Without the session token being passed in, AWS STS credentials,
will not be usable. This prevents some users from using assumed
roles, and the credentials supplied, for downloading from S3
based Maven repositories.
@ansibot
Copy link
Contributor

ansibot commented Feb 2, 2017

cc @chrisisbeef
click here for bot help

@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 community_review In order to be merged, this PR must follow the community review workflow. feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. labels Feb 2, 2017
@gzm55 gzm55 mentioned this pull request Feb 2, 2017
Closed
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Feb 3, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 11, 2017
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Jun 29, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2017

cc @tumbl3w33d
click here for bot help

@tumbl3w33d
Copy link
Contributor

LGTM, however, I have no experience with AWS, so I can't tell if it's gonna work. Would be great if @ryansb could have a look.

@tumbl3w33d
Copy link
Contributor

shipit

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Dec 9, 2017
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 2, 2018
@ansibot
Copy link
Contributor

ansibot commented Mar 18, 2018

cc @turb
click here for bot help

@turb
Copy link
Contributor

turb commented Mar 19, 2018

;@mrcrilly I can now join @tumbl3w33d to merge it. Just have to rebase and solve conflicts

@ansibot ansibot added the needs_info This issue requires further information. Please answer any outstanding questions. label Mar 19, 2018
@ansibot ansibot removed the needs_info This issue requires further information. Please answer any outstanding questions. label Mar 27, 2018
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Jul 25, 2018
@ansibot ansibot added the packaging Packaging category label Feb 18, 2019
@gundalow gundalow added the pr_day Has been reviewed during a PR review Day label Sep 19, 2019
@gundalow
Copy link
Contributor

@mrcrilly
Thank you for your PR.
As part of reviewing the backlog of PRs we are looking at PRs older PRs that haven't been updated in a while

Given that:

  • Needed a rebase since end of 2017
  • This is a feature rather than a bug fix

Therefore I'm going to close this.

If you or anyone else wants to continue with this work then please do feel free to create a fresh PR and @mention the previous reviewers in here.

@gundalow gundalow closed this Sep 19, 2019
@ansible ansible locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.3 This issue/PR affects Ansible v2.3 feature This issue/PR relates to a feature request. has_issue module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. packaging Packaging category pr_day Has been reviewed during a PR review Day stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mrcrilly @ansibot @tumbl3w33d @turb @gundalow @ryansb @s-hertel