Fix firewalld get_masquerade_enabled_permanent error #21693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_masquerade_* functions only take one arg. The action_handler
wrapper function expected a tuple, but was being passed (zone)
instead of (zone,) making for an ambiquous tuple. The
(zone) arg was being treated as a tuple/list of six chars
(the zone name) instead of a tuple of one string.
This would cause errors like:
get_masquerade_enabled_permanent() takes exactly 1 argument (6 given)
Fixes #21632
ansibot
added
affects_2.3
|
shipit 👍 |
ansibot
removed
the
needs_triage
navyzet
added a commit
to navyzet/ansible-role-openvpn
that referenced
this pull request
Jun 20, 2017
"ERROR: Exception caught: set_masquerade_enabled() takes exactly 1 argument (6 given)" ansible/ansible#21693
kelbyers
added a commit
to kelbyers/ansible-role-openvpn
that referenced
this pull request
Aug 30, 2017
ERROR: Exception caught: set_masquerade_enabled() takes exactly 1 argument (6 given)" ansible/ansible#21693
kyl191
pushed a commit
to kyl191/ansible-role-openvpn
that referenced
this pull request
Aug 30, 2017
* workaround ansible issue "set_masquerade_enabled" ERROR: Exception caught: set_masquerade_enabled() takes exactly 1 argument (6 given)" ansible/ansible#21693 * my fork not in ansible galaxy * make sure crl database file exists * Revert "my fork not in ansible galaxy" This reverts commit af1d9c3.
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_masquerade_* functions only take one arg. The action_handler
wrapper function expected a tuple, but was being passed (zone)
instead of (zone,) making for an ambiquous tuple. The
(zone) arg was being treated as a tuple/list of six chars
(the zone name) instead of a tuple of one string.
This would cause errors like:
Fixes #21632
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/system/firewalld.py
ANSIBLE VERSION
SUMMARY