Check for imports to be between last doc line and first callable

[sivel]

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

validate-modules

ANSIBLE VERSION

devel

SUMMARY

This change checks whether imports are between the last doc line and the first callable.

This will cause an error for imports at the bottom for new modules. Displays a warning for legacy modules.

Example output:

./test/sanity/validate-modules/validate-modules lib/ansible/modules/cloud/rackspace/rax.py -w
============================================================================
lib/ansible/modules/cloud/rackspace/rax.py
============================================================================
WARNING:312:No RETURN provided
WARNING:208:module_utils imports should import specific components, not "*". line 893
WARNING:208:module_utils imports should import specific components, not "*". line 894
WARNING:107:Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA. line 893
WARNING:107:Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA. line 894

[sivel]

/cc @mattclay @gundalow