add (un)silence_nagios and command actions to the nagios module

[skvidal]

also fix a typo with the check_mode check

this just adds a raw command action, changes the default requirements for running an action and fixes up the notification formatting for the above.

[skvidal]

I'd also like to loop @tbielawa into this for review since he wrote the original one.

[tbielawa]

Will check this out this weekend.

[tbielawa]

Doc string says command is required: true but AnsibleModule says command=dict(required=False, default=None),

[tbielawa]

I can confirm that silence_nagios and unsilence_nagios work as advertised!

[tbielawa]

I can confirm that the command action works as advertised.

+1 once the documentation typo is corrected.

[mpdehaan]

is there a pull request to fix the docs?

On Sat, Mar 2, 2013 at 3:36 PM, tbielawa notifications@github.com wrote:

I can confirm that the command action works as advertised.

+1 once the documentation typo is corrected.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2272#issuecomment-14335188
.

[skvidal]

command is required if action=command.

it can't be required in the command dict() b/c it is not required in EVERY case.

Same as host is not required for silence_nagios but it is for every other action.

How should this be fixed?

[mpdehaan]

Is there actually a problem? I'm deferring to you guys here :)

[mpdehaan]

cricket.

@skvidal @tbielawa -- you guys agree this is good to merge or is something still outstanding?

Thanks!

[tbielawa]

Ship it
On Mar 10, 2013 6:39 PM, "Michael DeHaan" notifications@github.com wrote:

cricket.

@skvidal https://github.com/skvidal @tbielawahttps://github.com/tbielawa-- you guys agree this is good to merge or is something still outstanding?

Thanks!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2272#issuecomment-14691076
.

[mpdehaan]

go-go-gadget-merge-button

merged, thanks!