Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport 2.3: Fix stderr false return value #22846

Closed
wants to merge 2 commits into from
Closed

backport 2.3: Fix stderr false return value #22846

wants to merge 2 commits into from

Conversation

tedder
Copy link
Contributor

@tedder tedder commented Mar 21, 2017 •
edited by ansibot

SUMMARY

Backporting #22845.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

uri module

ANSIBLE VERSION

2.4

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 c:plugins/action core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category labels Mar 21, 2017
@Qalthos Qalthos removed the needs_triage Needs a first human triage before being processed. label Mar 23, 2017
@ansibot ansibot added feature_pull_request stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 8, 2017
@calfonso calfonso added net_tools Net-tools category and removed networking Network category labels May 19, 2017
@calfonso
Copy link
Contributor

needs_rebase

@tedder
ensure exit_json does not fail from stderr=False
6172d12 
- do a little bit of safety-checking in exit_json to not try to .splitlines() on a boolean
- remove the stderr=boolean from uri.py, this is the only spot that uses it (at least so obviously)
- add unit tests that call exit_json. These are useless because the stderr parsing is in _execute_module and is difficult to mock; deleting these tests after the commit.
@tedder
remove added unit tests per prev commit
0d02c5c 
exit_json doesn't do the param parsing, that is buried deep inside _execute_module.
@tedder tedder force-pushed the fix_stderr_false_return_value_patch23 branch from e22a957 to 0d02c5c Compare May 19, 2017 20:01
@ansibot ansibot removed core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 19, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 1, 2017
@ansibot ansibot added backport This PR does not target the devel branch. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 27, 2017
@ansibot
Copy link
Contributor

ansibot commented Nov 17, 2017

cc @romeotheriault
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. labels Nov 17, 2017
@ansibot ansibot added affects_2.3 This issue/PR affects Ansible v2.3 and removed affects_2.4 This issue/PR affects Ansible v2.4 labels Jan 28, 2018
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 2, 2018
@ansibot ansibot removed the core_review In order to be merged, this PR must follow the core review workflow. label May 21, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels May 21, 2018
@mattclay
Copy link
Member

Ansible 2.3 has reached end-of-life and is no longer supported.

See release and maintenance status for additional details.

@mattclay mattclay closed this May 22, 2018
@ansible ansible locked and limited conversation to collaborators May 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.3 This issue/PR affects Ansible v2.3 backport This PR does not target the devel branch. c:plugins/action feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. net_tools Net-tools category owner_pr This PR is made by the module's maintainer. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tedder @calfonso @ansibot @mattclay @Qalthos