command: Remove executable parameter when using command #23062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nitzmahone @jimi-c @bcoca Is this implementation acceptable ? |
ansibot
added
affects_2.4
nitzmahone
approved these changes
Mar 29, 2017
Qalthos
removed
the
needs_triage
ansibot
added
the
stale_ci
|
@nitzmahone The empty warnings was not a concern to me, I simply wanted to make use of the new module.warn() infrastructure. More examples of it in use may help people do the right thing :-) @bcoca So what needs to happen to get this going ? |
ansibot
added
needs_rebase
dagwieers
force-pushed
the
win_command-executable
branch
from
2639b13
to
01c37c2
Compare
ansibot
removed
module
abadger
reviewed
Jul 11, 2017
| @@ -157,6 +141,10 @@ def main(): | |||
| removes = module.params['removes'] | |||
| warn = module.params['warn'] | |||
|
|
|||
| if not shell and executable: | |||
| module.warn('The parameter "executable" is not supported with the "command" module. Not using "%s".' % executable) | |||
There was a problem hiding this comment.
Maybe add the version executable went away:
module.warn('As of Ansible 2.4, the parameter "executable" is no longer supported with the "command" module. Not using "%s".' % executable) There was a problem hiding this comment.
Changed. Thanks !
dagwieers
force-pushed
the
win_command-executable
branch
2 times, most recently
from
00cecef
to
5094b33
Compare
This was discussed with the core team and removing this option was preferred. For backward compatibility we accept the parameter, but warn the user instead.
dagwieers
force-pushed
the
win_command-executable
branch
from
5094b33
to
201d719
Compare
ansibot
added
needs_ci
|
merged to devel. Thanks dag! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This was discussed with the core team and removing this option was preferred.
For backward compatibility we accept the parameter, but warn the user instead.
This PR also includes a change related to warnings, we now use the warning-infrastructure, this avoids empty warnings-dictionary in the output if there's no warning.
ISSUE TYPE
COMPONENT NAME
command
ANSIBLE VERSION
v2.4