Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powershell: Add support for list parameters #23131

Merged
merged 1 commit into from
May 9, 2017
Merged

powershell: Add support for list parameters #23131

merged 1 commit into from
May 9, 2017

Conversation

dagwieers
Copy link
Contributor

SUMMARY

This is a first implementation of list parameters.

It will convert a single string, or comma-separated value into an Array.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

powershell

ANSIBLE VERSION

v2.3

@dagwieers
powershell: Add support for list parameters
c40cd77 
This is a first implementation of list parameters.

It will convert a single string, or comma-separated value into an Array.
@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 c:module_utils/ feature_pull_request needs_triage Needs a first human triage before being processed. windows Windows community needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 30, 2017
@dagwieers dagwieers mentioned this pull request Mar 30, 2017
Merged
dagwieers added a commit to dagwieers/ansible that referenced this pull request Mar 30, 2017
@dagwieers
win_defrag: New module to defragment local volumes
0d64a06 
This module performs defragmentation on local Windows volumes.

This module requires PR ansible#23131 for list parameter support.
@dagwieers
Copy link
Contributor Author

dagwieers commented Mar 30, 2017 •
edited
Loading

Shippable error unrelated to changes. Windows tests take longer than VM lifetime.
https://app.shippable.com/github/ansible/ansible/runs/17713/9/console

@jhawkesworth
Copy link
Contributor

Nice feature.
I wondered if it ought to support some other delimiters (like | as used in win_iis_webapppool but... may as well keep it simple for now (I don't actually know if python args have similar).

shipit

@dagwieers
Copy link
Contributor Author

Close and reopen to redo Shippable run.

@dagwieers dagwieers closed this Mar 30, 2017
@dagwieers dagwieers reopened this Mar 30, 2017
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Mar 31, 2017
@nitzmahone nitzmahone removed the needs_triage Needs a first human triage before being processed. label Mar 31, 2017
@jborean93
Copy link
Contributor

would be good to have, I know there are a few modules where I've got this logic in there manually. One thing that would be great to have is to specify the type of elements in the list, i.e. it's a list of paths so it expands the strings but simple is good :)

shipit

@dagwieers
Copy link
Contributor Author

@jborean93 I agree it would be useful to indicate the type of list-elements, however I don't think there's an implementation for Python modules. And I did not want to introduce new capabilities in the Windows modules.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 11, 2017
@dagwieers dagwieers mentioned this pull request May 8, 2017
Closed
@nitzmahone nitzmahone merged commit 5ab97b3 into ansible:devel May 9, 2017
dpiotrowski pushed a commit to dpiotrowski/ansible that referenced this pull request May 9, 2017
@dagwieers @dpiotrowski
powershell: Add support for list parameters (ansible#23131)
c7f7276 
This is a first implementation of list parameters.

It will convert a single string, or comma-separated value into an Array.
KKoukiou pushed a commit to KKoukiou/ansible that referenced this pull request May 22, 2017
@dagwieers @KKoukiou
powershell: Add support for list parameters (ansible#23131)
29e5ea5 
This is a first implementation of list parameters.

It will convert a single string, or comma-separated value into an Array.
nitzmahone pushed a commit that referenced this pull request Jun 7, 2017
@dagwieers @nitzmahone
win_defrag: New module to defragment local volumes (#23140)
656db37 
This module performs defragmentation on local Windows volumes.

This module requires PR #23131 for list parameter support.
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 c:module_utils/ feature This issue/PR relates to a feature request. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dagwieers @jhawkesworth @jborean93 @nitzmahone @ansibot