Fortios file only mode + integration tests #23275

bjolivot · 2017-04-04T21:26:40Z

SUMMARY

As Fortigate device could not be buy for only ansible tests, I have added file mode in fortios module_utils helper.
File mode mean that module work with only configuration file level, without device needed \o/.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

module_utils/fortios.py

ANSIBLE VERSION

ansible 2.4.0 (fortios_file_only_mode c8cafae84a) last updated 2017/04/04 23:18:30 (GMT +200)

ADDITIONAL INFORMATION

ansibot · 2017-04-04T22:12:21Z

The test ansible-test sanity --test integration-aliases failed with the following error:

Command "test/sanity/code-smell/integration-aliases.py" returned exit status 1.
>>> Standard Output
The following integration target directories are missing `aliases` files:

test/integration/targets/fortios_ipv4_policy

If these tests cannot be run as part of CI (requires external services, unsupported dependencies, etc.),
then they most likely belong in `test/integration/roles/` instead of `test/integration/targets/`.
In that case, do not add an `aliases` file. Instead, just relocate the tests.

However, if you think that the tests should be able to be supported by CI, please discuss test
organization with @mattclay or @gundalow on GitHub or #ansible-devel on IRC.

If these tests can be run as part of CI, you'll need to add an appropriate CI alias, such as:

posix/ci/group1
windows/ci/group2

The CI groups are used to balance tests across multiple jobs to minimize test run time.
Using the relevant `group1` entry is fine in most cases. Groups can be changed later to redistribute tests.

Aliases can also be used to express test requirements:

needs/privileged
needs/root
needs/ssh

Other aliases are used to skip tests under certain conditions:

skip/freebsd
skip/osx
skip/python3

Take a look at existing `aliases` files to see what aliases are available and how they're used.

The test ansible-test sanity --test yamllint failed with the following errors:

test/integration/targets/fortios_ipv4_policy/tasks/test_indempotency.yml:69:1: too many blank lines (1 > 0) (empty-lines)
test/integration/targets/fortios_ipv4_policy/tasks/test_params.yml:76:1: too many blank lines (1 > 0) (empty-lines)

click here for bot help

ansibot · 2017-04-05T07:49:02Z

The test ansible-test sanity --test integration-aliases failed with the following error:

Command "test/sanity/code-smell/integration-aliases.py" returned exit status 1.
>>> Standard Output
The following integration target directories are missing `aliases` files:

test/integration/targets/fortios_ipv4_policy

If these tests cannot be run as part of CI (requires external services, unsupported dependencies, etc.),
then they most likely belong in `test/integration/roles/` instead of `test/integration/targets/`.
In that case, do not add an `aliases` file. Instead, just relocate the tests.

However, if you think that the tests should be able to be supported by CI, please discuss test
organization with @mattclay or @gundalow on GitHub or #ansible-devel on IRC.

If these tests can be run as part of CI, you'll need to add an appropriate CI alias, such as:

posix/ci/group1
windows/ci/group2

The CI groups are used to balance tests across multiple jobs to minimize test run time.
Using the relevant `group1` entry is fine in most cases. Groups can be changed later to redistribute tests.

Aliases can also be used to express test requirements:

needs/privileged
needs/root
needs/ssh

Other aliases are used to skip tests under certain conditions:

skip/freebsd
skip/osx
skip/python3

Take a look at existing `aliases` files to see what aliases are available and how they're used.

click here for bot help

gundalow · 2017-04-05T20:35:16Z

I see you have the aliases set now, which looks good.
I've been busy with 2.3 stuff, so apologies for not having time on IRC, we can have the discussion here.

Could you please rebase your PR

ansibot · 2017-04-06T13:05:10Z

@bjolivot this PR contains the following merge comits:

0c48d7c

Please rebase your branch to remove these commits.

click here for bot help

ansibot · 2017-04-06T13:05:12Z

@bjolivot this PR contains the following merge comits:

0c48d7c

Please rebase your branch to remove these commits.

click here for bot help

Create mutualy_exclusive param Fix yamllint problem in tests

mattclay · 2017-04-07T20:36:52Z

CI failure in integration tests on centos6:

https://app.shippable.com/github/ansible/ansible/runs/18428/12/console

The error was: Could not import the python library pyFG required by this module

bjolivot · 2017-04-10T09:53:04Z

ready_for_review

gundalow · 2017-04-10T10:01:11Z

test/integration/fortios.yml

@@ -0,0 +1,9 @@
+---


I don't think you need this file as ansible-test will create one, also it could get out of sync with the actual tests.

ansible-test integration -vvve fortios.*

The -e means explain, notice that a Playbook is generated on the fly

gundalow · 2017-04-10T10:03:09Z

test/integration/targets/fortios_ipv4_policy/tasks/test_params.yml

+     id: 42
+     src_addr: all
+     dst_addr: all
+     # policy_action: accept


What's this comment about, left over from development?

It's not left over.
I assert that missing required param thow an exception, for all these test, I comment the param line.

gundalow · 2017-04-10T10:07:34Z

From a quick review it looks good. Will review in more detail when I get a chance.

A number of files appear to be missing newlines, could you please fix that, thanks.

missing new lines at end of file

bjolivot · 2017-04-13T09:34:29Z

ready_for_review

bjolivot · 2017-05-05T08:10:51Z

bot_status

ansibot · 2017-05-05T08:16:57Z

waiting_on: ansible
component: None
supported_by: core
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
mergeable_state: clean
shippable_status: success
maintainer_shipits: False
community_shipits: False
ansible_shipits: False
shipit_actors: None

click here for bot help

* WIP file_mode * WIP * Add file_mode + integration tests * fix pep8 * Update doc fragments Create mutualy_exclusive param Fix yamllint problem in tests * Add aliases file + main playbook for fortios * Install pyfg before running tests * Install pyfg before running tests in role * Remove pre_task as it's done in roles * Force pyFG minimal version for python3 * role_path not role_dir :( * Change requirements * Specify Error type when error on import * Bug in pygf library with python 2.5 (PR is waiting spotify/pyfg#19) * Bad requirement format * still bad format -_-' * remove test/integration/fortios.py (auto generated by tests) missing new lines at end of file * pyFG is now fixed in 0.50

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 4, 2017

ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Apr 5, 2017

gundalow requested review from mattclay and gundalow April 5, 2017 20:35

gundalow removed the needs_triage Needs a first human triage before being processed. label Apr 5, 2017

ansibot added the merge_commit This PR contains at least one merge commit. Please resolve! label Apr 6, 2017

bjolivot and others added 9 commits April 6, 2017 15:31

WIP file_mode

8d40099

WIP

a1a3fcc

Add file_mode + integration tests

821eda1

fix pep8

1e2a3e2

Update doc fragments

e1221a9

Create mutualy_exclusive param Fix yamllint problem in tests

Add aliases file + main playbook for fortios

712fe69

Install pyfg before running tests

3339e6f

Install pyfg before running tests in role

ed992a4

Remove pre_task as it's done in roles

4d606da

bjolivot force-pushed the fortios_file_only_mode branch from 0c48d7c to 4d606da Compare April 6, 2017 13:41

mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Apr 7, 2017

Specify Error type when error on import

a463cc3

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Apr 10, 2017

bjolivot added 3 commits April 10, 2017 10:43

Bug in pygf library with python 2.5 (PR is waiting spotify/pyfg#19)

85b984f

Bad requirement format

c93562f

still bad format -_-'

96c6203

ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Apr 10, 2017

gundalow reviewed Apr 10, 2017

View reviewed changes

bjolivot added 2 commits April 10, 2017 12:25

remove test/integration/fortios.py (auto generated by tests)

83c391b

missing new lines at end of file

pyFG is now fixed in 0.50

8b7d67e

gundalow approved these changes Apr 13, 2017

View reviewed changes

mattclay approved these changes Apr 28, 2017

View reviewed changes

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 28, 2017

gundalow closed this May 9, 2017

gundalow reopened this May 9, 2017

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 9, 2017

gundalow merged commit e99815e into ansible:devel May 9, 2017

bjolivot mentioned this pull request May 15, 2017

Manage Fortios/Fortigate Address #21542

Merged

ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 4, 2018

dagwieers added the fortios Fortios community label Feb 22, 2019

ansible locked and limited conversation to collaborators Apr 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fortios file only mode + integration tests #23275

Fortios file only mode + integration tests #23275

bjolivot commented Apr 4, 2017

ansibot commented Apr 4, 2017

ansibot commented Apr 5, 2017

gundalow commented Apr 5, 2017

ansibot commented Apr 6, 2017

ansibot commented Apr 6, 2017

mattclay commented Apr 7, 2017

bjolivot commented Apr 10, 2017

gundalow Apr 10, 2017

bjolivot Apr 10, 2017

gundalow Apr 10, 2017

bjolivot Apr 10, 2017

gundalow commented Apr 10, 2017

bjolivot commented Apr 13, 2017

bjolivot commented May 5, 2017

ansibot commented May 5, 2017

Fortios file only mode + integration tests #23275

Fortios file only mode + integration tests #23275

Conversation

bjolivot commented Apr 4, 2017

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

ADDITIONAL INFORMATION

ansibot commented Apr 4, 2017

ansibot commented Apr 5, 2017

gundalow commented Apr 5, 2017

ansibot commented Apr 6, 2017

ansibot commented Apr 6, 2017

mattclay commented Apr 7, 2017

bjolivot commented Apr 10, 2017

gundalow Apr 10, 2017

Choose a reason for hiding this comment

bjolivot Apr 10, 2017

Choose a reason for hiding this comment

gundalow Apr 10, 2017

Choose a reason for hiding this comment

bjolivot Apr 10, 2017

Choose a reason for hiding this comment

gundalow commented Apr 10, 2017

bjolivot commented Apr 13, 2017

bjolivot commented May 5, 2017

ansibot commented May 5, 2017