Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New module: Add Uptrends module. (monitoring/uptrends) #24111

Closed
wants to merge 3 commits into from
Closed

New module: Add Uptrends module. (monitoring/uptrends) #24111

wants to merge 3 commits into from

Conversation

gormux
Copy link

@gormux gormux commented Apr 28, 2017

SUMMARY

Added module monitoring/uptrends

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

uptrends

ANSIBLE VERSION
ansible 2.3.0.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides
  python version = 2.7.13 (default, Feb 11 2017, 12:22:40) [GCC 6.3.1 20170109]
ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. labels Apr 28, 2017
@ansibot
Copy link
Contributor

ansibot commented Apr 28, 2017

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 28, 2017
@ansibot
Copy link
Contributor

ansibot commented Apr 28, 2017

The test ansible-test sanity --test validate-modules failed with the following errors:

lib/ansible/modules/monitoring/uptrends.py:0:0: E101 Interpreter line is not "#!/usr/bin/python"
lib/ansible/modules/monitoring/uptrends.py:0:0: E105 GPLv3 license header not found
lib/ansible/modules/monitoring/uptrends.py:0:0: E203 requests import found, should use ansible.module_utils.urls instead
lib/ansible/modules/monitoring/uptrends.py:0:0: E208 module_utils imports should import specific components, not "*". line 41
lib/ansible/modules/monitoring/uptrends.py:0:0: E305 DOCUMENTATION.version_added: required key not provided @ data['version_added']. Got None
lib/ansible/modules/monitoring/uptrends.py:0:0: E307 version_added should be 2.4. Currently 0.0
lib/ansible/modules/monitoring/uptrends.py:0:0: E312 No RETURN documentation provided
lib/ansible/modules/monitoring/uptrends.py:0:0: E314 No ANSIBLE_METADATA provided

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Apr 28, 2017
@ansibot
Copy link
Contributor

ansibot commented Apr 28, 2017

The test ansible-test sanity --test validate-modules failed with the following errors:

lib/ansible/modules/monitoring/uptrends.py:0:0: E203 requests import found, should use ansible.module_utils.urls instead
lib/ansible/modules/monitoring/uptrends.py:0:0: E312 No RETURN documentation provided
lib/ansible/modules/monitoring/uptrends.py:0:0: E316 ANSIBLE_METADATA.metadata_version: required key not provided @ data['metadata_version']. Got None
lib/ansible/modules/monitoring/uptrends.py:0:0: E316 ANSIBLE_METADATA.version: extra keys not allowed @ data['version']. Got '1.0'

click here for bot help

@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Apr 28, 2017
@alikins alikins changed the title Added uptrends module New module: Add Uptrends module. (monitoring/uptrends) May 22, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 22, 2017
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Jun 29, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Oct 18, 2017
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Nov 3, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Jan 22, 2018
@ansibot ansibot added the monitoring Monitoring category label Feb 17, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Apr 15, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Apr 17, 2019
@mattclay mattclay mentioned this pull request Apr 17, 2019
Closed
@ansibot ansibot added the needs_repo This PR no longer has an associated branch as it was removed by the submitter. label Jun 12, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 31, 2019

@gormux Your branch does not contain a shippable.yml file. Please rebase your branch to trigger running of current tests.

click here for bot help

@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jul 31, 2019
@ansibot ansibot added the needs_shippable This PR lacks a shippable.yml in its tree. Please rebase your branch to include the latest CI tests. label Jul 31, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 31, 2019

@gormux Your branch does not contain a shippable.yml file. Please rebase your branch to trigger running of current tests.

click here for bot help

@gundalow gundalow added candidate_to_close Think we can close this, though need to check with Core pr_day Has been reviewed during a PR review Day labels Sep 3, 2019
@gundalow
Copy link
Contributor

gundalow commented Sep 3, 2019

Hi,
Thank you for this PR. Though for the following reasons we will close this:

  • PR hasn't been modified since 2017
  • Module is only a thin wrapper around the URI module
  • Source repo no longer exists.

@gundalow gundalow closed this Sep 3, 2019
@ansible ansible locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.4 This issue/PR affects Ansible v2.4 candidate_to_close Think we can close this, though need to check with Core ci_verified Changes made in this PR are causing tests to fail. has_issue module This issue/PR relates to a module. monitoring Monitoring category needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_repo This PR no longer has an associated branch as it was removed by the submitter. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_shippable This PR lacks a shippable.yml in its tree. Please rebase your branch to include the latest CI tests. new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. pr_day Has been reviewed during a PR review Day stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gormux @ansibot @gundalow @mattclay @s-hertel