adds jinja2 filters for working with network devices

[privateip]

• adds network textfsm filters
• adds network config filter

[ansibot]

@privateip Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

• issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

[ansibot]

cc @dharmabumstead
click here for bot help

[gundalow]

For code blocks in RST you use ::, blank line, four spaces

e.g.

To generate a list of command diffs for a network configuration::

    {{ myvar | diff_network_config(current_config, indent=1 }}

[gundalow]

I wonder if this should be called NETWORK_OS_INDENT, or similar

[gundalow]

Might be worth adding some comments to say why you set the proxy to localhost.

[ansibot]

The test ansible-test sanity --test ansible-var-precedence-check failed with the following error:

Command "test/sanity/code-smell/ansible-var-precedence-check.py" returned exit status 1.
>>> Standard Output
CHECKING: extra_vars (var passed via the cli)
ERROR !!!
playbook failed (rc=2), stdout: 'b'\nPLAY [testhost] ****************************************************************\n\nTASK [set_fact] ****************************************************************\nok: [testhost]\n\nTASK [include_vars] ************************************************************\nok: [testhost]\n\nTASK [debug] *******************************************************************\nAn exception occurred during task execution. To see the full traceback, use -vvv. The error was: ImportError: No module named \'urllib2\'\nfatal: [testhost]: FAILED! => {"failed": true, "msg": "Unexpected failure during module execution.", "stdout": ""}\n\tto retry, use: --limit @/tmp/tmp4ymr89uu/site.retry\n\nPLAY RECAP *********************************************************************\ntesthost                   : ok=2    changed=0    unreachable=0    failed=1   \n\n'' stderr: 'b'''
feature: extra_vars failed

The test ansible-test sanity --test pep8 failed with the following errors:

lib/ansible/plugins/filter/network.py:50:1: E302 expected 2 blank lines, found 1
lib/ansible/plugins/filter/network.py:67:1: E302 expected 2 blank lines, found 1
lib/ansible/plugins/filter/network.py:103:1: E302 expected 2 blank lines, found 1
lib/ansible/plugins/filter/network.py:106:17: E222 multiple spaces after operator

The test ansible-test sanity --test replace-urlopen failed with the following error:

Command "test/sanity/code-smell/replace-urlopen.sh" returned exit status 1.
>>> Standard Output
./lib/ansible/plugins/filter/network.py:            resp = urllib2.urlopen(template)
One or more file(s) listed above use urlopen.
Use open_url from module_utils instead of urlopen.

click here for bot help

[jedelman8]

Glad to see TextFSM integration going into core.

Few questions for now.

• Are you doing anything with respect a template repository? I hope not.
• Are you open to having more options in the filter such as returning a list of dictionaries and normalizing the TextFSM object a bit more.
• Are you open to using the clitable and add inputs such as template directory, command, and platform?

[itdependsnetworks]

need to close out the function: e.g.
{{ myvar | diff_network_config(current_config, indent=1 ) }}

Also might be a good idea to show example using a file lookup.

[itdependsnetworks]

Not sure how this would ever hit base on the previous assert? Perhaps the assert should be here?

[itdependsnetworks]

Just want to confirm there is no namespace issue with filter_plugins, like there is with modules, e.g. the setup.py issue. Otherwise network.py may be too generic.

[privateip]

@jedelman8

Are you doing anything with respect a template repository? I hope not.

No, nothing planned

Are you open to having more options in the filter such as returning a list of dictionaries and normalizing the TextFSM object a bit more.

Can you elaborate more what you are thinking here?

Are you open to using the clitable and add inputs such as template directory, command, and platform?

I'm not sure this is needed as we the same thing can be easily accomplished in the playbook unless I'm not completely understanding what you are asking here. WRT clitable sure

[privateip]

@itdependsnetworks

Just want to confirm there is no namespace issue with filter_plugins, like there is with modules, e.g. the setup.py issue. Otherwise network.py may be too generic.

filters same as modules aren't namespaced, not sure what the concern here is

[gundalow]

I wonder if it would be worth adding this to CHANGELOG.md as well