Fixes #23285

[dsummersl]

Makes subversion module --check fail when modified files are in
repository.

SUMMARY

Checks that there are no local file modifications in the repository in check_mode (as long as force is also False).

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

subversion module

ANSIBLE VERSION

ansible 2.4.0 (issue-23285 0e02463a88) last updated 2017/05/04 07:58:25 (GMT -400)
  config file =
  configured module search path = [u'/Users/---/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/---/Documents/classes/ansible/lib/ansible
  executable location = /Users/---/Documents/classes/ansible/bin/ansible
  python version = 2.7.13 (default, Dec 18 2016, 07:03:39) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)]

ADDITIONAL INFORMATION

When the target host has a modified file in its repository it DOES NOT fail check mode. This fixes that issue.

Here I have setup a target with a subversion repository with a local modification (removed file).

# before change:
cat s.yml
---
- hosts: docker
  become: true
  tasks:
  - name: break subversion
    subversion:
      repo: file:///svnrepos/testproject
      dest: /root/svnrepo

ansible-playbook -i test_hosts s.yml --check
PLAY [docker] ********************************************************************************************************************************************************************

TASK [Gathering Facts] ***********************************************************************************************************************************************************
ok: [docker]

TASK [break subversion] **********************************************************************************************************************************************************
ok: [docker]

PLAY RECAP ***********************************************************************************************************************************************************************
docker                     : ok=2    changed=0    unreachable=0    failed=0

# this change:
cat s.yml
---
- hosts: docker
  become: true
  tasks:
  - name: break subversion
    subversion:
      repo: file:///svnrepos/testproject
      dest: /root/svnrepo

ansible-playbook -i test_hosts s.yml --check
PLAY [docker] ********************************************************************************************************************************************************************

TASK [Gathering Facts] ***********************************************************************************************************************************************************
ok: [docker]

TASK [break subversion] **********************************************************************************************************************************************************
fatal: [docker]: FAILED! => {"changed": false, "failed": true, "msg": "ERROR: modified files exist in the repository."}
        to retry, use: --limit @/Users/danesummers/Documents/classes/ansible/s.retry

PLAY RECAP ***********************************************************************************************************************************************************************
docker                     : ok=1    changed=0    unreachable=0    failed=1

# this change - with a playbook using subversion 'force' option.
cat s-force.yml
---
- hosts: docker
  become: true
  tasks:
  - name: break subversion
    subversion:
      repo: file:///svnrepos/testproject
      dest: /root/svnrepo
      force: true

ansible-playbook -i test_hosts s-force.yml --check
PLAY [docker] ********************************************************************************************************************************************************************

TASK [Gathering Facts] ***********************************************************************************************************************************************************
ok: [docker]

TASK [break subversion] **********************************************************************************************************************************************************
ok: [docker]

PLAY RECAP ***********************************************************************************************************************************************************************
docker                     : ok=2    changed=0    unreachable=0    failed=0

[nitzmahone]

cherry-picked to stable-2.3 for 2.3.1RC1