Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for ttl parameter to sensu_check #24309

Closed
wants to merge 2 commits into from

Conversation

dmizelle
Copy link

@dmizelle dmizelle commented May 4, 2017

SUMMARY

Sensu Check Definitions support the definition of a "time to live" for a check result. Ansible doesn't actually support setting it.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

sensu_check

ANSIBLE VERSION
ansible 2.2.1.0 (detached HEAD fe33c937c4) last updated 2017/04/12 12:03:14 (GMT -400)
  lib/ansible/modules/core: (detached HEAD 48a3ce1223) last updated 2017/04/12 12:03:15 (GMT -400)
  lib/ansible/modules/extras: (detached HEAD 4e720b48ae) last updated 2017/04/12 12:03:16 (GMT -400)
  config file = /home/devon/git/arin/ansible/ansible.cfg
  configured module search path = ['library']

ADDITIONAL INFORMATION

A tl;dr version is that if the sensu server doesnt see this check come back in x number of seconds, it turns it into alert.

It is perfect for making sure that checks don't "disappear" from hosts, but Ansible does not support defining it.

@ansibot
Copy link
Contributor

ansibot commented May 4, 2017

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 community_review In order to be merged, this PR must follow the community review workflow. feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. labels May 4, 2017
@dmizelle
Copy link
Author

dmizelle commented May 4, 2017

Also this is labelled as affects_2.4, but it really affects every ansible release where sensu_check is present, I guess. It'd be really really nice to have this backported to 2.2, 2.3, etc.

@nitzmahone nitzmahone removed the needs_triage Needs a first human triage before being processed. label May 4, 2017
@dmizelle
Copy link
Author

dmizelle commented May 5, 2017

Closing because #24184 is better (and I trust @dmsimard more than myself)

@dmizelle dmizelle closed this May 5, 2017
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants