Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the bigip_user module to Ansible #24753

Merged
merged 1 commit into from May 18, 2017

Conversation

caphrim007
Copy link
Contributor

SUMMARY

The patch adds the bigip_user module to Ansible to support managing
users on an F5 BIG-IP.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

lib/ansible/modules/network/f5/bigip_user.py

ANSIBLE VERSION
ansible 2.4.0 (feature.add-bigip-user-module 35118a6eb4) last updated 2017/05/17 13:32:10 (GMT -700)
  config file = 
  configured module search path = [u'/Users/trupp/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/trupp/src/trupp/ansible/lib/ansible
  executable location = /Users/trupp/src/trupp/ansible/bin/ansible
  python version = 2.7.10 (default, Feb  7 2017, 00:08:15) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.34)]
ADDITIONAL INFORMATION

Unit tests are provided. Integration tests can be found here

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. test_pull_requests labels May 17, 2017
@ansibot
Copy link
Contributor

ansibot commented May 17, 2017

The test ansible-test sanity --test shebang failed with the following error:

Command "test/sanity/code-smell/shebang.sh" returned exit status 1.
>>> Standard Output
./test/units/modules/network/f5/test_bigip_user.py:#!/usr/bin/python
One or more file(s) listed above have an unexpected shebang.
See test/sanity/code-smell/shebang.sh for the list of acceptable values.

The test ansible-test sanity --test validate-modules failed with the following errors:

lib/ansible/modules/network/f5/bigip_user.py:0:0: E305 DOCUMENTATION.options.partition_access.type: not a valid value for dictionary value @ data['options']['partition_access']['type']. Got 'list'
lib/ansible/modules/network/f5/bigip_user.py:0:0: E307 version_added should be 2.4. Currently 2.2

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 17, 2017
@caphrim007 caphrim007 force-pushed the feature.add-bigip-user-module branch from 35118a6 to f1123b4 Compare May 17, 2017 21:57
@caphrim007
Copy link
Contributor Author

@gundalow are the test files not allowed to include the shebang at the top?

@caphrim007 caphrim007 force-pushed the feature.add-bigip-user-module branch from f1123b4 to affc406 Compare May 17, 2017 22:06
@ansibot
Copy link
Contributor

ansibot commented May 17, 2017

The test ansible-test sanity --test validate-modules failed with the following error:

lib/ansible/modules/network/f5/bigip_user.py:0:0: E101 Interpreter line is not "#!/usr/bin/python"

click here for bot help

@caphrim007 caphrim007 force-pushed the feature.add-bigip-user-module branch from affc406 to eda2fc1 Compare May 17, 2017 22:47
@caphrim007 caphrim007 closed this May 17, 2017
@caphrim007 caphrim007 reopened this May 17, 2017
@caphrim007 caphrim007 force-pushed the feature.add-bigip-user-module branch from eda2fc1 to f4eb73a Compare May 18, 2017 00:10
@gundalow
Copy link
Contributor

  1. Regarding the requirements. I've spoken with Matt Clay. We are both happy for them to be in the main file. In the future we may add in support for splitting the requirement files out, but we don't have the need yet.

  2. Regarding the shebag.
    Unit tests shouldn't be executable. They also need to run under different versions of Python as specified by ansible-test

@gundalow gundalow added the ci_verified Changes made in this PR are causing tests to fail. label May 18, 2017
@gundalow gundalow self-assigned this May 18, 2017
@gundalow gundalow self-requested a review May 18, 2017 06:34
@gundalow
Copy link
Contributor

First new non-core module into 2.4 with Unit Tests, good stuff :)

units/2.6
failing with

2017-05-18 00:12:43   File "/root/src/github.com/ansible/ansible/test/runner/.tox/py26/lib/python2.6/site-packages/py/_builtin.py", line 221, in exec_
2017-05-18 00:12:43     exec2(obj, globals, locals)
2017-05-18 00:12:43   File "<string>", line 7, in exec2
2017-05-18 00:12:43   File "/root/src/github.com/ansible/ansible/test/runner/.tox/py26/lib/python2.6/site-packages/f5/bigip/cm/autodeploy/software_images.py", line 23, in <module>
2017-05-18 00:12:43     from f5.bigip.resource import PathElement
2017-05-18 00:12:43   File "/root/src/github.com/ansible/ansible/test/runner/.tox/py26/lib/python2.6/site-packages/f5/bigip/resource.py", line 722
2017-05-18 00:12:43     no_meta_dict = {k: v for k, v in self.__dict__.iteritems()

units/3.5 & units/3.6
Are failing with a variety of different errors

@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label May 18, 2017
@gundalow
Copy link
Contributor

--requirements docs updated c9e0595

The patch adds the bigip_user module to Ansible to support managing
users on an F5 BIG-IP.

Unit tests are provided. Integration tests can be found here

  * https://github.com/F5Networks/f5-ansible/blob/devel/test/integration/bigip_user.yaml
  * https://github.com/F5Networks/f5-ansible/tree/devel/test/integration/targets/bigip_user/tasks
@caphrim007 caphrim007 force-pushed the feature.add-bigip-user-module branch from f4eb73a to 58982f3 Compare May 18, 2017 18:39
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label May 18, 2017
@caphrim007
Copy link
Contributor Author

@gundalow ready_for_review

@gundalow gundalow merged commit c139762 into ansible:devel May 18, 2017
@gundalow
Copy link
Contributor

Coverage has been updated https://codecov.io/gh/ansible/ansible/tree/devel

KKoukiou pushed a commit to KKoukiou/ansible that referenced this pull request May 22, 2017
The patch adds the bigip_user module to Ansible to support managing
users on an F5 BIG-IP.

Unit tests are provided. Integration tests can be found here

  * https://github.com/F5Networks/f5-ansible/blob/devel/test/integration/bigip_user.yaml
  * https://github.com/F5Networks/f5-ansible/tree/devel/test/integration/targets/bigip_user/tasks
@caphrim007 caphrim007 deleted the feature.add-bigip-user-module branch September 11, 2017 20:07
@dagwieers dagwieers added the f5 label Sep 27, 2017
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 f5 module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants