Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for asa_config #25319 #25680

Closed
wants to merge 1 commit into from
Closed

Fix for asa_config #25319 #25680

wants to merge 1 commit into from

Conversation

ogenstad
Copy link
Contributor

SUMMARY

This would fix #25319, however more things will need to be done to restore the full functionality of the ASA modules.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • asa_config
ANSIBLE VERSION
ansible 2.4.0 (asa_config 2c86bd2b72) last updated 2017/06/14 09:43:22 (GMT +200)
  config file =
  configured module search path = [u'/Users/patrick/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/patrick/src/forks/ansible/lib/ansible
  executable location = /Users/patrick/src/forks/ansible/bin/ansible
  python version = 2.7.12 (default, Dec  5 2016, 11:55:02) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)]
ADDITIONAL INFORMATION

I don't like the way I solved this, and this is mostly pushed to show what could be done. The changes to shell.py have been done so that it shouldn't impact any other module. However there's a good chance that other modules using that code doesn't work now either.

@ogenstad ogenstad mentioned this pull request Jun 14, 2017
Closed
@ansibot
Copy link
Contributor

ansibot commented Jun 14, 2017

cc @gundalow
click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 bugfix_pull_request c:module_utils/ community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. labels Jun 14, 2017
@gundalow gundalow mentioned this pull request Jun 14, 2017
Closed
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Jun 14, 2017
@gundalow
Copy link
Contributor

I've added this to the agenda for the Network IRC meeting

Qalthos
Qalthos suggested changes Jun 14, 2017
View reviewed changes
lib/ansible/module_utils/shell.py
sendonly=dict(default=False)
), module)
else:
transform = ComplexDict(dict(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's any reason to keep this path, ComplexDict needs a module parameter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this was just to get it working and not touch anything for other modules. But I agree that this and other things needs to be changed.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jun 14, 2017
@gundalow
Copy link
Contributor

Discussed in IRC Meeting https://meetbot.fedoraproject.org/ansible-meeting/2017-06-14/network_working_group.2017-06-14-16.02.log.html

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. labels Jun 23, 2017
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jul 18, 2017
@ogenstad ogenstad closed this Jul 24, 2017
@ogenstad ogenstad deleted the asa_config branch July 24, 2017 07:12
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added asa Cisco ASA community cisco Cisco technologies labels Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos requested changes

Assignees

@privateip privateip

Labels
affects_2.4 This issue/PR affects Ansible v2.4 asa Cisco ASA community bug This issue/PR relates to a bug. c:module_utils/ cisco Cisco technologies module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category owner_pr This PR is made by the module's maintainer. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

asa_config issue
6 participants
@ogenstad @ansibot @gundalow @Qalthos @dagwieers @privateip