Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use standard service commands on freebsd #25751

Closed
wants to merge 1 commit into from
Closed

use standard service commands on freebsd #25751

wants to merge 1 commit into from

Conversation

thnee
Copy link
Contributor

@thnee thnee commented Jun 15, 2017 •
edited

SUMMARY

Uses standard service commands instead of the commands prefixed with one. The commands prefixed with one are not functionally equivalent, and not what you would expect as the default mode of operation for a service module.

Fixes #25743

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module/system/service

ANSIBLE VERSION
ansible 2.3.0.0
  config file = /path/playbooks/ansible.cfg
  configured module search path = [u'../library/']
  python version = 2.7.13 (default, Apr 29 2017, 01:15:48) [GCC 4.2.1 Compatible FreeBSD Clang 3.8.0 (tags/RELEASE_380/final 262564)]
ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. labels Jun 15, 2017
@bcoca
Copy link
Member

bcoca commented Jun 15, 2017

this breaks backwards compatibility, the issue deals with a service compromised of multiple services which can be individually enabled/disabled. This was done to make sure that the module would start/stop the service no matter what the configuration set as default.

this is a special case, not sure how to approach it.

@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jun 15, 2017
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 27, 2017
@bcoca bcoca self-assigned this Aug 18, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Oct 18, 2017
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Nov 3, 2017
@maxamillion
Copy link
Contributor

needs_info

@ansibot ansibot added needs_info This issue requires further information. Please answer any outstanding questions. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 13, 2017
@ansibot ansibot added the new_contributor This PR is the first contribution by a new community member. label Jan 22, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 31, 2018

@thnee This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 2, 2018
@ansibot
Copy link
Contributor

ansibot commented Mar 10, 2018

@thnee This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Mar 18, 2018

@thnee You have not responded to information requests in this pullrequest so we will assume it no longer affects you. If you are still interested in this, please create a new pullrequest with the requested information.

click here for bot help

@ansibot ansibot closed this Mar 18, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bcoca bcoca

Labels
affects_2.4 This issue/PR affects Ansible v2.4 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_info This issue requires further information. Please answer any outstanding questions. new_contributor This PR is the first contribution by a new community member. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Service module uses commands prefixed with 'one' on FreeBSD
4 participants
@thnee @bcoca @maxamillion @ansibot