Lambda modules refactored to use new ansible.module_utils.aws.core.

[mikedlr]

SUMMARY

This PR modifies the lambda and lambda_fact to use the new ansible.module_utils.aws module and shows the benefits of doing so. The changes currently include all changes included in #25780 so that the new lambda changes work. Since the new module utils have now been merged this is a stand alone fix which can be merged.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

lambda module
lambda_fact module

ANSIBLE VERSION

ansible 2.4.0 (lambda_using_new_aws_utils e16bda5837) last updated 2017/06/24 18:13:49 (GMT +100)
  config file = None
  configured module search path = [u'/home/mikedlr/dev/ansible/ansible-dev/library']
  ansible python module location = /home/mikedlr/dev/ansible/ansible-dev/lib/ansible
  executable location = /home/mikedlr/dev/ansible/ansible-dev/bin/ansible
  python version = 2.7.5 (default, Nov  6 2016, 00:28:07) [GCC 4.8.5 20150623 (Red Hat 4.8.5-11)]

ADDITIONAL INFORMATION

this PR currently serves

• to demonstrate how ansible.module_utils.aws can improve AWS module development
• to run integration tests against aws.core in new aws dir in module utils - module with AnsibleAWSModule class and fail_json_aws #25780

once #25780 is merged then this should be rebased off devel and then merged. (rebase done)

The only changes to command behaviour should be more consistent and complete exception handling in the modules. Further testing encouraged.

[ansibot]

cc @pjodouin
click here for bot help

[ansibot]

The test ansible-test sanity --test pep8 failed with the following errors:

test/sanity/pep8/legacy-files.txt:55:1: A201 Remove "lib/ansible/modules/cloud/amazon/lambda.py" since it passes the current rule set
test/sanity/pep8/legacy-files.txt:56:1: A201 Remove "lib/ansible/modules/cloud/amazon/lambda_facts.py" since it passes the current rule set

The test ansible-test sanity --test pylint failed with the following error:

lib/ansible/modules/cloud/amazon/lambda.py:306:16: redundant-keyword-arg Argument 'msg' passed by position and keyword in method call

click here for bot help

[mattclay]

I added WIP to the labels and title since this is waiting on another PR.

[mattclay]

@mikedlr Since this includes all changes from #25780, it should be passing CI, correct?

[ansibot]

The test ansible-test sanity --test pep8 failed with the following errors:

lib/ansible/module_utils/aws.py:81:1: W293 blank line contains whitespace
test/units/module_utils/aws/test_aws_module.py:50:17: E225 missing whitespace around operator
test/units/module_utils/aws/test_aws_module.py:51:25: E225 missing whitespace around operator
test/units/module_utils/aws/test_aws_module.py:55:16: E713 test for membership should be 'not in'

click here for bot help

[ansibot]

The test ansible-test sanity --test pep8 failed with the following error:

lib/ansible/module_utils/aws.py:53:29: W291 trailing whitespace

click here for bot help

[ansibot]

The test ansible-test sanity --test pep8 failed with the following errors:

lib/ansible/modules/cloud/amazon/lambda.py:322:47: E231 missing whitespace after ','
lib/ansible/modules/cloud/amazon/lambda.py:322:61: E231 missing whitespace after ','

click here for bot help

[ansibot]

The test ansible-test sanity --test pep8 failed with the following errors:

lib/ansible/modules/cloud/amazon/lambda.py:364:15: E271 multiple spaces after keyword
lib/ansible/modules/cloud/amazon/lambda.py:485:15: E271 multiple spaces after keyword

click here for bot help