Fix Python3 Errors in Azure Cloud Module

[rajasaur]

SUMMARY

When using Python3, the exec_module function errors out with a
unsupported operand type(s) for +: 'dict_keys' and 'list'
error when adding the .keys() to a static list. Use the explicit
list function to make a list of keys and then add to the ['tags'] list.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

• cloud/azure

ANSIBLE VERSION

ansible 2.4.0 (python3_azure e9f6d02e69) last updated 2017/06/26 11:44:44 (GMT +550)
  config file = None
  configured module search path = ['/Users/raja/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /private/tmp/ansible/lib/ansible
  executable location = /private/tmp/ansible/bin/ansible
  python version = 3.6.0 (default, Dec 30 2016, 23:33:29) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)]

ADDITIONAL INFORMATION

When running azure modules under Python3, there are errors of the form:

TypeError: unsupported operand type(s) for +: 'dict_keys' and 'list'

This is because of calls like

self.module_arg_spec.keys() + ['tags']:

Replacing them with

list(self.module_arg_spec.keys()) + ['tags']:

fixes the issue. This is now done in the pull request for various azure sub commands

[ansibot]

cc @haroldwongms @tstringer @nitzmahone
click here for bot help

[trstringer]

This looks good to me.

[trstringer]

I'm currently working on PR #24710 and I'd like to get this PR merged and rebased into my parent PR for it.

@nitzmahone since this is a multi-file PR and ansibot won't allow maintainers to automerge this one, could we get this merged in?

[abadger]

Thanks for the work on this. Anytime I see combinations of lists like this which are then used just to do containment tests I think there is probably a better way. However, it isn't that important to have the perfect solution and this code is definitely an improvement. Merged to devel and cherry-picking to the 2.3 branch after 2.3.2 comes out (so it will be in 2.3.3 if we have a 2.3.3 release).