New module - elb_target

[wimnat]

SUMMARY

New module - elb_target

ISSUE TYPE

• New Module Pull Request

COMPONENT NAME

elb_target

ANSIBLE VERSION

2.5

ADDITIONAL INFORMATION

@willthames @s-hertel

[wimnat]

@jbscare

[ansibot]

The test ansible-test sanity --test pep8 failed with the following errors:

lib/ansible/modules/cloud/amazon/elb_target.py:72:1: W293 blank line contains whitespace
lib/ansible/modules/cloud/amazon/elb_target.py:80:1: W293 blank line contains whitespace

click here for bot help

[s-hertel]

If the TargetHealthDescriptions are an empty list this will fail. Maybe check if it exists and if not return an empty dict?
Traceback:

The full traceback is:
Traceback (most recent call last):
  File "/var/folders/by/k8_fbl593dlctgqmwq5wzl2c0000gn/T/ansible_mqh88b9h/ansible_module_elb_target.py", line 245, in <module>
    main()
  File "/var/folders/by/k8_fbl593dlctgqmwq5wzl2c0000gn/T/ansible_mqh88b9h/ansible_module_elb_target.py", line 242, in main
    deregister_target(connection, module)
  File "/var/folders/by/k8_fbl593dlctgqmwq5wzl2c0000gn/T/ansible_mqh88b9h/ansible_module_elb_target.py", line 205, in deregister_target
    target_descriptions = describe_targets(connection, module, target_group_arn, [])
  File "/var/folders/by/k8_fbl593dlctgqmwq5wzl2c0000gn/T/ansible_mqh88b9h/ansible_module_elb_target.py", line 125, in describe_targets
    return connection.describe_target_health(TargetGroupArn=tg_arn, Targets=target)['TargetHealthDescriptions'][0]
IndexError: list index out of range

fatal: [localhost]: FAILED! => {
    "changed": false,
    "failed": true,
    "module_stderr": "Traceback (most recent call last):\n  File \"/var/folders/by/k8_fbl593dlctgqmwq5wzl2c0000gn/T/ansible_mqh88b9h/ansible_module_elb_target.py\", line 245, in <module>\n    main()\n  File \"/var/folders/by/k8_fbl593dlctgqmwq5wzl2c0000gn/T/ansible_mqh88b9h/ansible_module_elb_target.py\", line 242, in main\n    deregister_target(connection, module)\n  File \"/var/folders/by/k8_fbl593dlctgqmwq5wzl2c0000gn/T/ansible_mqh88b9h/ansible_module_elb_target.py\", line 205, in deregister_target\n    target_descriptions = describe_targets(connection, module, target_group_arn, [])\n  File \"/var/folders/by/k8_fbl593dlctgqmwq5wzl2c0000gn/T/ansible_mqh88b9h/ansible_module_elb_target.py\", line 125, in describe_targets\n    return connection.describe_target_health(TargetGroupArn=tg_arn, Targets=target)['TargetHealthDescriptions'][0]\nIndexError: list index out of range\n",
    "module_stdout": "",
    "msg": "MODULE FAILURE",
    "rc": 0
}

PLAY RECAP *************************************************************************************************************
localhost                  : ok=0    changed=0    unreachable=0    failed=1

[s-hertel]

Also, what if the target has been registered on multiple ports (since running the playbook with a new port doesn't deregister the target with the old port)? Should those be in the returned info as well, instead of just the first item in the list?

[kernow]

@wimnat I've been using this module and encountered an issue with the way you are handling existing targets, attempting to register or deregister an existing target causes an exception. In both register_target and deregister_target the code relies on the Reason being supplied in the TargetHealth object. This fails when the targets health state is healthy as the Reason is not supplied by the api when the state is healthy. See: TargetHealth API docs

As the State may or may not be returned I believe you will first need to check if the State is present, if it's not then check if a Reason is present, then check for the value of the Reason

[ansibot]

Components

lib/ansible/modules/cloud/amazon/elb_target.py
support: community
maintainers:

test/integration/targets/elb_target/aliases
support: community
maintainers:

test/integration/targets/elb_target/defaults/main.yml
support: community
maintainers:

test/integration/targets/elb_target/tasks/main.yml
support: community
maintainers:

Metadata

waiting_on: wimnat
changes_requested_by: null
needs_info: False
needs_revision: True
needs_rebase: False
merge_commits: []
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): False
community_shipits (namespace maintainers): False
ansible_shipits (core team members): False
shipit_actors (maintainer or core team member): None
shipit_actors_other:

click here for bot help

[s-hertel]

!needs_revision

[tedder]

testing locally.

[tedder]

fixes my objection. shipit.

[s-hertel]

The bot was needs revision because there was an @ in a commit message. I rebased to remove that from the commit message.

[ansibot]

@Constantin007 @Constantin07 @Deepakkothandan @Etherdaemon @Java1Guy @Lujeni @Madhura-CSI @MichaelBaydoun @Sodki @adq @akazakov @alachaum @amir343 @anryko @bekelchik @bpennypacker @brandond @carsongee @defunctio @dkhenry @fiunchinho @fivethreeo @garethr @gunzy83 @gurumaia @hsingh @hyperized @iiibrad @infectsoldier @j-carl @jarv @Java1Guy @jimbydamonk @jmenga @joelthompson @jonhadfield @jonmer85 @joshsouza @jsdalton @jsmartin @kaczynskid @leedm777 @linuxdynasty @loia @lwade @MichaelBaydoun @michaeljs1990 @minichate @mjschultz @mmochan @nadirollo @nand0p @naslanidis @nickball @orthanc @piontas @pjodouin @prasadkatti @psykotox @pwnall @raags @rickmendes @roadmapper @ryansydnor @scicoin-project @scottanderson42 @shepdelacreme @silviud @steynovich @tastychutney @tedder @tgerla @timmahoney @tombamford @tsiganenok @viper233 @whiter @wilvk @zacblazic @zbal @zeekin @zimbatm

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help