Handle OSError: file exists exception #26580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.4
|
The test The test The test |
ansibot
added
ci_verified
alikins
removed
the
needs_triage
ansibot
removed
ci_verified
willthames
suggested changes
Jul 11, 2017
contrib/inventory/ec2.py
Outdated
| try: | ||
| os.makedirs(cache_dir) | ||
| except(OSError): | ||
| print('Cache directory already exists. Skipping the step...') |
There was a problem hiding this comment.
I don't think printing an informational message is that useful. Just pass here instead
| @@ -399,7 +399,10 @@ def read_settings(self): | |||
| if self.boto_profile: | |||
| cache_dir = os.path.join(cache_dir, 'profile_' + self.boto_profile) | |||
| if not os.path.exists(cache_dir): | |||
There was a problem hiding this comment.
This check is now fairly pointless. If we're going to just try/except, no point checking it first.
There was a problem hiding this comment.
@cazorla19 It seems like you still need to remove this line.
ansibot
added
the
needs_revision
ansibot
added
stale_ci
ansibot
added
c:inventory/contrib_script
support:community
ansibot
added
the
new_contributor
ansibot
removed
the
new_contributor
ansibot
added
the
new_contributor
ansibot
added
bug
|
I'm gonna close this as an outdated topic, even me completely lost the track of this issue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I appended the handling of situation where we run multiple inventory cache updates on one host from one user. It's not related to any issue in Github, but it's important anyway.
What's is the issue at all? Let's imagine that I'm running multiple Ansible playbooks on EC2 inventory at a time. There may be used just one node, but might be multiple, it depends on the CI choice. To have my cache fresh, I have to update this running
ec2.py --refresh-cachecommand. When cache will become empty, multiple processes will try to create a new directory and will fail doing this simultaneously.My way to fix this is tested. Please, check the accordance to your code style and merge if everything's fine.
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
contrib/inventory/ec2.pyANSIBLE VERSION
ADDITIONAL INFORMATION
To reproduce the error, you can run multiple EC2 inventory update processes. I'm not sure how to make it reproduced every time, because process may try to create the directory anytime and then avoid concurrency issue.