Ansible Config part2 #27448
Merged
Ansible Config part2 #27448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
WIP
bcoca
force-pushed
the
config_from_plugin_docs
branch
from
d9fdab6
to
b51e912
Compare
s-hertel
removed
the
needs_triage
bcoca
force-pushed
the
config_from_plugin_docs
branch
from
1c62bb5
to
ea23c4b
Compare
ansibot
added
the
needs_rebase
bcoca
force-pushed
the
config_from_plugin_docs
branch
from
ea23c4b
to
6555783
Compare
ansibot
added
c:cli/console
c:cli/pull
c:executor/task_executor
c:executor/task_queue_manager
c:parsing/mod_args
and removed
needs_rebase
bcoca
force-pushed
the
config_from_plugin_docs
branch
from
6555783
to
31892a6
Compare
ansibot
removed
the
WIP
ansibot
added
the
needs_revision
pilou-
reviewed
Aug 14, 2017
lib/ansible/cli/doc.py
Outdated
| for config in ('env', 'ini', 'yaml', 'vars'): | ||
| if config in opt and opt[config]: | ||
| conf[config] = opt.pop(config) | ||
| else: |
There was a problem hiding this comment.
else seems useless here, it could be removed (then if block below must be moved at the same level than the for loop).
pilou-
reviewed
Aug 14, 2017
lib/ansible/config/manager.py
Outdated
| Plugin = namedtuple('Plugin','name type') | ||
| Setting = namedtuple('Setting','name value origin') | ||
|
|
||
| IGNORE_CONFIGS = frozenset([None, '/dev/null']) |
There was a problem hiding this comment.
Should not it be os.devnull ?
There was a problem hiding this comment.
no, had to add the string as that is what test/ uses all over, still need to research why, but for now its here to make tests pass.
bcoca
force-pushed
the
config_from_plugin_docs
branch
from
31892a6
to
b8bbf2c
Compare
mattclay
added
the
ci_verified
bcoca
force-pushed
the
config_from_plugin_docs
branch
from
b8bbf2c
to
3161a21
Compare
ansibot
removed
the
ci_verified
bcoca
force-pushed
the
config_from_plugin_docs
branch
2 times, most recently
from
2724f45
to
4655767
Compare
- made dump_me nicer, added note this is not prod - moved internal key removal function to vars - carry tracebacks in errors we can now show tracebacks for plugins on vvv - show inventory plugin tracebacks on vvv - minor fixes to cg groups plugin - draft config from plugin docs - made search path warning 'saner' (top level dirs only) - correctly display config entries and others - removed unneeded code - commented out some conn plugin specific from base.yml - also deprecated sudo/su - updated ssh conn docs - shared get option method for connection plugins - note about needing eval for defaults - tailored yaml ext - updated strategy entry - for connection pliugins, options load on plugin load - allow for long types in definitions - better display in ansible-doc - cleaned up/updated source docs and base.yml - added many descriptions - deprecated include toggles as include is - draft backwards compat get_config - fixes to ansible-config, added --only-changed - some code reoorg - small license headers - show default in doc type - pushed module utils details to 5vs - work w/o config file - PEPE ATE! - moved loader to it's own file - fixed rhn_register test - fixed boto requirement in make tests - I ate Pepe - fixed dynamic eval of defaults - better doc code skip ipaddr filter tests when missing netaddr removed devnull string from config better becoem resolution
bcoca
force-pushed
the
config_from_plugin_docs
branch
from
0f5e1a0
to
21a4adb
Compare
cause its an affront against all that is holy that 2 spaces touch each other!
ansibot
added
feature
| network_os=('ansible_network_os', ), | ||
|
|
||
| # ssh TODO: remove |
There was a problem hiding this comment.
What's this TODO for? It's not obvious to me (from the large commit) why these should be removed. I use ansible_ssh_extra_args extensively. Will this be going away?
There was a problem hiding this comment.
no, it just lives in the ssh plugin, play_context doesn't need to have it anymore
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
config
ANSIBLE VERSION