Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aci.py: Add use_proxy support #27735

Merged
merged 1 commit into from
Aug 7, 2017
Merged

aci.py: Add use_proxy support #27735

merged 1 commit into from
Aug 7, 2017

Conversation

dagwieers
Copy link
Contributor

SUMMARY

This PR includes:

  • Support for the use_proxy parameter
  • Additional notes related to proxy support and use_proxy parameter
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

module_utils/aci.py

ANSIBLE VERSION

v2.4

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 c:module_utils/ feature_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 4, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 4, 2017

The test ansible-test sanity --test pep8 failed with the following errors:

lib/ansible/module_utils/aci.py:152:9: E124 closing bracket does not match visual indentation
lib/ansible/module_utils/aci.py:183:9: E124 closing bracket does not match visual indentation
lib/ansible/module_utils/aci.py:209:9: E124 closing bracket does not match visual indentation
lib/ansible/module_utils/aci.py:237:1: W391 blank line at end of file

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 4, 2017
@dagwieers
aci.py: Add use_proxy support
144760e 
This PR includes:
- Support for the use_proxy parameter
- Additional notes related to proxy support and use_proxy parameter
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 4, 2017
@dagwieers
Copy link
Contributor Author

cc: @schunduri

resmo
resmo reviewed Aug 4, 2017
View reviewed changes
lib/ansible/utils/module_docs_fragments/aci.py
description:
- If C(no), it will not use a proxy, even if one is defined in an environment variable on the target hosts.
default: 'yes'
type: bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing version_added: '2.4'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, there were no ACI modules in v2.4, so everything is new.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, my bad.

Copy link
Contributor Author

@dagwieers dagwieers Aug 4, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries !

@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Aug 4, 2017
@resmo resmo merged commit ca7ce44 into ansible:devel Aug 7, 2017
@dagwieers dagwieers added the aci Cisco ACI community label Sep 27, 2017
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@dagwieers dagwieers added cisco Cisco technologies networking Network category labels Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo left review comments

Assignees
No one assigned
Labels
aci Cisco ACI community affects_2.4 This issue/PR affects Ansible v2.4 c:module_utils/ cisco Cisco technologies feature This issue/PR relates to a feature request. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dagwieers @ansibot @resmo @s-hertel