Rename Openswitch to Libreswitch #27971
Conversation
|
@gundalow @privateip Please have a look at it. |
|
@skg-net this PR contains more than one new module. Please submit only one new module per pullrequest. For further explanation, please read grouped module documentation |
ansibot
added
affects_2.4
Qalthos
removed
the
needs_triage
|
@skg-net are you planning on maintaining this module and addressing issues with it in the future? I am given to understand that even without the name change, these modules were not working properly. |
|
@Qalthos No, I am not planning to own/maintain these modules. My understanding is if you try with new openswitch modules, it wont work, since its a completely different NOS. But if you try to run with the old openswitch (now libreswitch) it should work. Since we are going to upload the new openswitch modules, I am just trying to cleanup the namespace. |
| @@ -38,7 +38,7 @@ The following is a list of module_utils files and a general description. The mod | |||
| - network.py - Functions for running commands on networking devices | |||
| - nxos.py - Contains definitions and helper functions specific to Cisco NXOS networking devices | |||
| - openstack.py - Utilities for modules that work with Openstack instances. | |||
| - openswitch.py - Definitions and helper functions for modules that manage OpenSwitch devices | |||
| - libreswitch.py - Definitions and helper functions for modules that manage libreswitch devices | |||
There was a problem hiding this comment.
This list should be in alphabetical order.
| lib/ansible/modules/network/openswitch/ops_command.py | ||
| lib/ansible/modules/network/openswitch/ops_config.py | ||
| lib/ansible/modules/network/openswitch/ops_facts.py | ||
| lib/ansible/modules/network/libreswitch/ops_command.py |
|
@gundalow The new modules will be called opx_base_xxxx. |
| @@ -126,7 +126,7 @@ | |||
| """ | |||
| import traceback | |||
|
|
|||
| import ansible.module_utils.openswitch | |||
| import ansible.module_utils.libreswitch | |||
There was a problem hiding this comment.
too keep compatibility for those using the old name of the lib, this should be a try/except Import with fallback to the old name.
|
any plans on renaming the modules themselves? ops_ vs lbs_ ? |
ansibot
added
needs_rebase
|
Since you have neither tested these modules nor do you have any interest in maintaining these modules, we are not going to merge this PR. Good news for you, though is that we have decided instead to just get rid of the modules entirely. This was decided as the modules do not work at all presently. That being said, if anyone in the future wishes to use this as a base for new LibreSwitch modules, the files are still in git history available for retrofitting. |
ansibot
added
bug
SUMMARY
The old openswitch(ops) (HP) NOS has been migrated to Libreswitch. There is now a new openswitch (opx) NOS supported by Dell and other vendors.
Hence moving the old openswitch modules to libreswitch folders.
ISSUE TYPE
COMPONENT NAME
module/network/openswitch
module/network/libreswitch
ANSIBLE VERSION
ansible --version
ansible 2.4.0 (libreswitch a86782e) last updated 2017/08/09 09:22:17 (GMT -700)
config file = None
configured module search path = [u'/home/sganesan/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /home/sganesan/github/ansible/lib/ansible
executable location = /home/sganesan/github/ansible/bin/ansible
python version = 2.7.11 |Continuum Analytics, Inc.| (default, Dec 6 2015, 18:08:32) [GCC 4.4.7 20120313 (Red Hat 4.4.7-1)]
ADDITIONAL INFORMATION
Currently the modules names remain ops
* the new openswitch have a different short form opx
* all the existing tests/playbooks needs to change.
* libreswitch community haven't got back on the naming convention.
I haven't tested this changes, since libreswitch image is not available currently.