New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New cloudformation dry run module for Ansible check mode #27995
Conversation
The test
The test
The test
The test
The test
The test
The test
The test
The test
The test
The test
The test
|
Could I please get a human reviewer here letting me know how to fix
|
The test
The test
The test
The test
The test
The test
The test
The test
The test
The test
The test
The test
|
Can this be done by adding check mode and diff capability to the existing cloudformation module? I'm not in favour of a specific diff module when ansible has a diff mode that we'd just need to hook in to. |
Ansible uses /usr/bin/python as a shebang, and will do python replacement at module execution time. There are various reasons for this (for one, it's how
These are mostly YAML errors. In particular you need to be careful with colons - YAML thinks that a colon followed by a space is a dictionary key/value separator. You'll also need a
You need to wrap the import in a |
The test
The test
The test
The test
The test
The test
The test
The test
The test
|
The test
The test
|
@willthames thanks for helping me out.
I also thought about this too prior creating a dedicated module. However with Cloudformation there is no real dry run yet. If this was integrated in Therefore I have created a separate module which is a pure You can for example:
And the above options to ignore should be adjusted per case... So I guess it is better to make this a separate module, stating that it is only a best guess. Once Cloudformation itself offers a dry run, that part should go into the original module and mine should be removed. |
The test
|
@Constantin07 @Etherdaemon @Lujeni @MichaelBaydoun @Sodki @adq @akazakov @alachaum @amir343 @anryko @bekelchik @bpennypacker @brandond @carsongee @dkhenry @fiunchinho @garethr @gunzy83 @hyperized @j-carl @jarv @Java1Guy @jmenga @joelthompson @jonhadfield @jsdalton @jsmartin @kaczynskid @leedm777 @linuxdynasty @loia @lwade @MichaelBaydoun @michaeljs1990 @minichate @mjschultz @mmochan @nadirollo @nand0p @naslanidis @NickBall @pjodouin @psykotox @pwnall @raags @RickMendes @roadmapper @ryansydnor @scicoin-project @scottanderson42 @shepdelacreme @silviud @simplesteph @steynovich @tastychutney @tedder @tgerla @timmahoney @tombamford @whiter @wilvk @wimnat @zacblazic @zbal @zeekin @zimbatm As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add |
@willthames why has the label |
|
SUMMARY
An Ansible module that will show the differences that would occur in case you actually run cloudformation_module. Changes to be shown include:
Changes that can be omitted by the module:
NoEcho: true
json
oryaml
depending on your preferred choice to view the diff.ISSUE TYPE
COMPONENT NAME
cloudformation_diff
ANSIBLE VERSION
ADDITIONAL INFORMATION
For reference see here: https://github.com/cytopia/ansible-modules