Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cloudformation dry run module for Ansible check mode #27995

Closed
wants to merge 14 commits into from
Closed

New cloudformation dry run module for Ansible check mode #27995

wants to merge 14 commits into from

Conversation

cytopia
Copy link

@cytopia cytopia commented Aug 10, 2017

SUMMARY

An Ansible module that will show the differences that would occur in case you actually run cloudformation_module. Changes to be shown include:

  • Stack template changes
  • Stack parameter changes
  • Stack tag changes

Changes that can be omitted by the module:

  • Stack template description
  • Stack parameters that use NoEcho: true
  • The diff output can be in json or yaml depending on your preferred choice to view the diff.
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

cloudformation_diff

ANSIBLE VERSION
ansible 2.3.2.0
  config file =
  configured module search path = Default w/o overrides
  python version = 3.5.3 (default, Jan 19 2017, 14:11:04) [GCC 6.3.0 20170118]
ADDITIONAL INFORMATION

For reference see here: https://github.com/cytopia/ansible-modules

@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2017

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 aws cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 10, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2017

The test ansible-test compile --python 2.6 failed with the following error:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:288:53: SyntaxError: return {quote_json(key):quote_json(value) for key, value in obj.items()}

The test ansible-test sanity --test ansible-doc --python 2.6 failed with the following error:

Command "ansible-doc cloudformation_diff" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/cloud/amazon/cloudformation_diff.py
ERROR! module cloudformation_diff missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 failed with the following error:

Command "ansible-doc cloudformation_diff" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/cloud/amazon/cloudformation_diff.py
ERROR! module cloudformation_diff missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 failed with the following error:

Command "ansible-doc cloudformation_diff" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/cloud/amazon/cloudformation_diff.py
ERROR! module cloudformation_diff missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 failed with the following error:

Command "ansible-doc cloudformation_diff" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/cloud/amazon/cloudformation_diff.py
ERROR! module cloudformation_diff missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test import --python 2.6 failed with the following error:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:288:53: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 2.7 failed with the following error:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:178:0: ImportError: No module named cfn_flip

The test ansible-test sanity --test import --python 3.5 failed with the following error:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:178:0: ImportError: No module named 'cfn_flip'

The test ansible-test sanity --test import --python 3.6 failed with the following error:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:178:0: ModuleNotFoundError: No module named 'cfn_flip'

The test ansible-test sanity --test pep8 failed with the following errors:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:29:161: E501 line too long (254 > 160 characters)
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:220:55: E231 missing whitespace after ','
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:226:13: E265 block comment should start with '# '
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:236:13: E265 block comment should start with '# '
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:246:13: E225 missing whitespace around operator
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:288:32: E231 missing whitespace after ':'
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:358:5: E303 too many blank lines (2)
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:448:33: E712 comparison to True should be 'if cond is True:' or 'if cond:'
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:495:33: E712 comparison to True should be 'if cond is True:' or 'if cond:'
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:507:5: E303 too many blank lines (2)
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:513:5: E303 too many blank lines (2)
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:523:13: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:523:15: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:524:16: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:524:18: E251 unexpected spaces around keyword / parameter equals

The test ansible-test sanity --test pylint failed with the following error:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:283:44: undefined-variable Undefined variable 'long'

The test ansible-test sanity --test validate-modules failed with the following errors:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:0:0: E101 Interpreter line is not "#!/usr/bin/python"
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:0:0: E304 Unknown DOCUMENTATION error, see TRACE
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:0:0: E305 DOCUMENTATION.options.ignore_hidden_params.description.0: expected str @ data['options']['ignore_hidden_params']['description'][0]. Got {"In parameter diff mode, ignore any template parameters with 'NoEcho": "true'"}
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:0:0: E305 DOCUMENTATION.requirements.2: expected str @ data['requirements'][2]. Got {'cfn_flip python module': 'C(pip install cfn_flip)'}
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:0:0: E312 No RETURN provided
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:283:0: E403 Type comparison using type() found. Use isinstance() instead

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 10, 2017
@cytopia
Copy link
Author

cytopia commented Aug 10, 2017

Could I please get a human reviewer here letting me know how to fix

  • Shebang: what is wrong with #!/usr/bin/env python
  • Unable to parse documentation
  • and ModuleNotFoundError: No module named 'cfn_flip' (which is required)

@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2017

The test ansible-test compile --python 2.6 failed with the following error:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:289:53: SyntaxError: return {quote_json(key):quote_json(value) for key, value in obj.items()}

The test ansible-test sanity --test ansible-doc --python 2.6 failed with the following error:

Command "ansible-doc cloudformation_diff" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/cloud/amazon/cloudformation_diff.py
ERROR! module cloudformation_diff missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 failed with the following error:

Command "ansible-doc cloudformation_diff" returned exit status 1.
>>> Standard Error
ERROR! module cloudformation_diff missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 failed with the following error:

Command "ansible-doc cloudformation_diff" returned exit status 1.
>>> Standard Error
ERROR! module cloudformation_diff missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 failed with the following error:

Command "ansible-doc cloudformation_diff" returned exit status 1.
>>> Standard Error
ERROR! module cloudformation_diff missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test import --python 2.6 failed with the following error:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:289:53: SyntaxError: invalid syntax

The test ansible-test sanity --test import --python 2.7 failed with the following error:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:179:0: ImportError: No module named cfn_flip

The test ansible-test sanity --test import --python 3.5 failed with the following error:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:179:0: ImportError: No module named 'cfn_flip'

The test ansible-test sanity --test import --python 3.6 failed with the following error:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:179:0: ModuleNotFoundError: No module named 'cfn_flip'

The test ansible-test sanity --test pep8 failed with the following errors:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:31:161: E501 line too long (254 > 160 characters)
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:221:55: E231 missing whitespace after ','
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:227:13: E265 block comment should start with '# '
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:237:13: E265 block comment should start with '# '
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:247:13: E225 missing whitespace around operator
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:289:32: E231 missing whitespace after ':'
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:359:5: E303 too many blank lines (2)
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:449:33: E712 comparison to True should be 'if cond is True:' or 'if cond:'
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:496:33: E712 comparison to True should be 'if cond is True:' or 'if cond:'
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:508:5: E303 too many blank lines (2)
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:514:5: E303 too many blank lines (2)
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:524:13: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:524:15: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:525:16: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:525:18: E251 unexpected spaces around keyword / parameter equals

The test ansible-test sanity --test pylint failed with the following error:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:284:44: undefined-variable Undefined variable 'long'

The test ansible-test sanity --test validate-modules failed with the following errors:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:0:0: E101 Interpreter line is not "#!/usr/bin/python"
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:0:0: E305 DOCUMENTATION.options.ignore_hidden_params.description.0: expected str @ data['options']['ignore_hidden_params']['description'][0]. Got {"In parameter diff mode, ignore any template parameters with 'NoEcho": "true'."}
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:0:0: E312 No RETURN provided
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:284:0: E403 Type comparison using type() found. Use isinstance() instead

click here for bot help

@willthames
Copy link
Contributor

Can this be done by adding check mode and diff capability to the existing cloudformation module?

I'm not in favour of a specific diff module when ansible has a diff mode that we'd just need to hook in to.

@willthames
Copy link
Contributor

Could I please get a human reviewer here letting me know how to fix

Shebang: what is wrong with #!/usr/bin/env python

Ansible uses /usr/bin/python as a shebang, and will do python replacement at module execution time. There are various reasons for this (for one, it's how ansible_python_interpreter works)

Unable to parse documentation

These are mostly YAML errors. In particular you need to be careful with colons - YAML thinks that a colon followed by a space is a dictionary key/value separator.

You'll also need a RETURN section. See the documentation docs.

and ModuleNotFoundError: No module named 'cfn_flip' (which is required)

You need to wrap the import in a try/except ImportError and set a variable that is then used later once the AnsibleModule is created so that you can do module.fail_json(msg="Cannot import cfn_flip. Try pip install cfn_flip or similar"). This is relatively well documented in the new module checklist page

@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2017

The test ansible-test compile --python 2.6 failed with the following error:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:300:53: SyntaxError: return {quote_json(key):quote_json(value) for key, value in obj.items()}

The test ansible-test sanity --test ansible-doc --python 2.6 failed with the following error:

Command "ansible-doc cloudformation_diff" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/cloud/amazon/cloudformation_diff.py
ERROR! module cloudformation_diff missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.7 failed with the following error:

Command "ansible-doc cloudformation_diff" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/cloud/amazon/cloudformation_diff.py
ERROR! module cloudformation_diff missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 failed with the following error:

Command "ansible-doc cloudformation_diff" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/cloud/amazon/cloudformation_diff.py
ERROR! module cloudformation_diff missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 failed with the following error:

Command "ansible-doc cloudformation_diff" returned exit status 1.
>>> Standard Error
[ERROR]: unable to parse /root/src/github.com/ansible/ansible/lib/ansible/modu
les/cloud/amazon/cloudformation_diff.py
ERROR! module cloudformation_diff missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test import --python 2.6 failed with the following error:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:300:53: SyntaxError: invalid syntax

The test ansible-test sanity --test pep8 failed with the following errors:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:31:161: E501 line too long (254 > 160 characters)
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:232:55: E231 missing whitespace after ','
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:238:13: E265 block comment should start with '# '
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:248:13: E265 block comment should start with '# '
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:258:13: E225 missing whitespace around operator
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:300:32: E231 missing whitespace after ':'
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:303:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:312:38: E231 missing whitespace after ':'
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:315:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:381:5: E303 too many blank lines (2)
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:474:10: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:475:10: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:476:10: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:477:10: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:478:10: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:479:10: E111 indentation is not a multiple of four
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:482:5: E303 too many blank lines (2)
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:489:33: E712 comparison to True should be 'if cond is True:' or 'if cond:'
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:536:33: E712 comparison to True should be 'if cond is True:' or 'if cond:'
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:548:5: E303 too many blank lines (2)
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:554:5: E303 too many blank lines (2)
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:564:13: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:564:15: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:565:16: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:565:18: E251 unexpected spaces around keyword / parameter equals

The test ansible-test sanity --test pylint failed with the following errors:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:295:44: undefined-variable Undefined variable 'long'
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:307:44: undefined-variable Undefined variable 'long'

The test ansible-test sanity --test validate-modules failed with the following errors:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:0:0: E312 No RETURN provided
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:81:1: E302 DOCUMENTATION is not valid YAML
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:295:0: E403 Type comparison using type() found. Use isinstance() instead
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:307:0: E403 Type comparison using type() found. Use isinstance() instead

click here for bot help

@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Aug 10, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2017

The test ansible-test sanity --test import --python 2.6 failed with the following error:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:190:0: ImportError: cannot import name OrderedDict

The test ansible-test sanity --test pylint failed with the following errors:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:307:47: undefined-variable Undefined variable 'long'
lib/ansible/modules/cloud/amazon/cloudformation_diff.py:322:47: undefined-variable Undefined variable 'long'

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 10, 2017
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 10, 2017
@cytopia
Copy link
Author

cytopia commented Aug 10, 2017

@willthames thanks for helping me out.

Can this be done by adding check mode and diff capability to the existing cloudformation module?

I'm not in favour of a specific diff module when ansible has a diff mode that we'd just need to hook in to.

I also thought about this too prior creating a dedicated module. However with Cloudformation there is no real dry run yet.

If this was integrated in cloudformation_module it should be 100% reliable and tell you if changes will occur or not. But this is not the case. Even though you would change the Cloudformation template (differing from remote), the stack might not be applied right away. Some examples are Stack description or some changes that happen within the CloudInit section. Additionally, if you have parameter that are set to NoEcho: true, they will always report as changed as the remote side reports them as ****** instead of the real value.

Therefore I have created a separate module which is a pure diff module that is also tweakable in the way you want your diff (changes) to be shown.

You can for example:

  • Ignore unecho-ed parameters
  • Ignore trailing newlines
  • Ignore stack descriptions

And the above options to ignore should be adjusted per case... So I guess it is better to make this a separate module, stating that it is only a best guess.

Once Cloudformation itself offers a dry run, that part should go into the original module and mine should be removed.

@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2017

The test ansible-test sanity --test import --python 2.6 failed with the following error:

lib/ansible/modules/cloud/amazon/cloudformation_diff.py:284:0: NameError: name 'OrderedDict' is not defined

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 10, 2017
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 10, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 10, 2017

@Constantin07 @Etherdaemon @Lujeni @MichaelBaydoun @Sodki @adq @akazakov @alachaum @amir343 @anryko @bekelchik @bpennypacker @brandond @carsongee @dkhenry @fiunchinho @garethr @gunzy83 @hyperized @j-carl @jarv @Java1Guy @jmenga @joelthompson @jonhadfield @jsdalton @jsmartin @kaczynskid @leedm777 @linuxdynasty @loia @lwade @MichaelBaydoun @michaeljs1990 @minichate @mjschultz @mmochan @nadirollo @nand0p @naslanidis @NickBall @pjodouin @psykotox @pwnall @raags @RickMendes @roadmapper @ryansydnor @scicoin-project @scottanderson42 @shepdelacreme @silviud @simplesteph @steynovich @tastychutney @tedder @tgerla @timmahoney @tombamford @whiter @wilvk @wimnat @zacblazic @zbal @zeekin @zimbatm

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 10, 2017
@cytopia
Copy link
Author

cytopia commented Aug 16, 2017

@willthames why has the label ci_verified been removed?

@tedder
Copy link
Contributor

tedder commented Aug 22, 2017

close_me, this done in the cloudformation module with #23483. That'll cut down the parallel development

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 22, 2017
@ryansb ryansb closed this Aug 23, 2017
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 aws cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants