Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aci_tenant: Update to support check_mode #28090

Merged
merged 1 commit into from
Aug 11, 2017
Merged

Conversation

jmcgill298
Copy link
Contributor

@jmcgill298 jmcgill298 commented Aug 11, 2017

SUMMARY

Updates to aci_tenant to add support for check_mode.

This fixes issues raised in #26836

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aci_tenant

ANSIBLE VERSION
#ansible --version
ansible 2.4.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/etc/ntc/ansible-modules/']
  ansible python module location = /home/jmcgill/ans23/local/lib/python2.7/site-packages/ansible
  executable location = /home/jmcgill/ans23/bin/ansible
  python version = 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609]

@ansibot
Copy link
Contributor

ansibot commented Aug 11, 2017

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 community_review In order to be merged, this PR must follow the community review workflow. feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 11, 2017
@dagwieers dagwieers changed the title Update aci_tenant to support check_mode aci_tenant: Update to support check_mode Aug 11, 2017
Copy link
Contributor

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As I already reviewed this in https://github.com/datacenter/aci-ansible

@dagwieers
Copy link
Contributor

The integration tests require ACI infrastructure, but we are going to add them as soon as possible in a form acceptable to this project. Working on it.

@dagwieers
Copy link
Contributor

@privateip @devarshishah3 @jedelman8 @calfonso Your feedback is appreciated.

As this module is the first module in a larger set, so any feedback we can take into account for the other modules.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Aug 11, 2017
@dagwieers
Copy link
Contributor

shipit

@schunduri
Copy link
Contributor

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 11, 2017
@ansibot ansibot merged commit 8b92369 into ansible:devel Aug 11, 2017
@jmcgill298 jmcgill298 deleted the aci_tenant branch August 24, 2017 18:53
@dagwieers dagwieers added the aci Cisco ACI community label Sep 27, 2017
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aci Cisco ACI community affects_2.4 This issue/PR affects Ansible v2.4 automerge This PR was automatically merged by ansibot. cisco Cisco technologies feature This issue/PR relates to a feature request. module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants