Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new module: manage contracts on ACI fabrics [network/aci/aci_contract] #28093

Merged
merged 1 commit into from
Aug 14, 2017
Merged

new module: manage contracts on ACI fabrics [network/aci/aci_contract] #28093

merged 1 commit into from
Aug 14, 2017

Conversation

dagwieers
Copy link
Contributor

SUMMARY

Module to manage contracts on ACI fabrics.
This module is idempotent, and supports check-mode and has diff-support.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

aci_contract

ANSIBLE VERSION

v2.4

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 11, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 11, 2017

The test ansible-test sanity --test validate-modules failed with the following error:

lib/ansible/modules/network/aci/aci_contract.py:0:0: E314 No ANSIBLE_METADATA provided

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 11, 2017
@dagwieers
aci_contract: Manage contracts on ACI fabrics
b31e4b6 
Module to manage contracts on ACI fabrics.
This module is idempotent, and supports check-mode and has diff-support.
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 11, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 12, 2017

@jmcgill298 @schunduri

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 12, 2017
@jmcgill298
Copy link
Contributor

shipit

@alikins alikins removed the needs_triage Needs a first human triage before being processed. label Aug 14, 2017
@dagwieers dagwieers changed the title aci_contract: Manage contracts on ACI fabrics new module: manage contracts on ACI fabrics [network/aci/aci_contract] Aug 14, 2017
@dagwieers dagwieers merged commit d4fae9b into ansible:devel Aug 14, 2017
@dagwieers dagwieers added the aci Cisco ACI community label Sep 27, 2017
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@privateip privateip Awaiting requested review from privateip

@calfonso calfonso Awaiting requested review from calfonso

Assignees
No one assigned
Labels
aci Cisco ACI community affects_2.4 This issue/PR affects Ansible v2.4 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dagwieers @ansibot @jmcgill298 @alikins