New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new module: panos_query_rules #28301
Conversation
@ivanbojer this PR contains the following merge commits: Please rebase your branch to remove these commits. |
The test
The test
|
@ivanbojer this PR contains the following merge commits: Please rebase your branch to remove these commits. |
@ivanbojer are you able to rebase your PR by following the docs at http://docs.ansible.com/ansible/latest/dev_guide/developing_rebasing.html |
ready_for_review |
@ivanbojer @jtschichold @rnh556 As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add |
Rebase needed, and unit test need to be added |
…an be as general or specific as needed. The policy rules are compared against the incoming traffic in sequence, and because the first rule that matches the traffic is applied, the more specific rules must precede the more general ones.
Rebase done! We cannot do unit tests in this release as that would need publicly accessible device. |
Didn't make it for 2.4 |
@ivanbojer We can help you get this into Ansible 2.5 if you want to reopen the PR... |
Unit tests don't need a publicly accessible device, you can mock out the data, see other network modules unit tests |
SUMMARY
Search for security rules matching specific criteria
ISSUE TYPE
COMPONENT NAME
panos_query_rules
ANSIBLE VERSION
ADDITIONAL INFORMATION
N/A