Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new module: panos_query_rules #28301

Closed
wants to merge 3 commits into from
Closed

new module: panos_query_rules #28301

wants to merge 3 commits into from

Conversation

ivanbojer
Copy link
Contributor

SUMMARY

Search for security rules matching specific criteria

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

panos_query_rules

ANSIBLE VERSION
ansible 2.3.0.0
  config file = 
  configured module search path = Default w/o overrides
  python version = 2.7.13 (default, Feb  6 2017, 11:22:10) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)]
ADDITIONAL INFORMATION

N/A

@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2017

@ivanbojer this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 16, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2017

The test ansible-test sanity --test pylint failed with the following errors:

lib/ansible/modules/network/panos/panos_query_rules.py:214:30: undefined-variable Undefined variable 'unicode'
lib/ansible/modules/network/panos/panos_query_rules.py:218:39: undefined-variable Undefined variable 'unicode'
lib/ansible/modules/network/panos/panos_query_rules.py:223:41: undefined-variable Undefined variable 'unicode'
lib/ansible/modules/network/panos/panos_query_rules.py:224:41: undefined-variable Undefined variable 'unicode'
lib/ansible/modules/network/panos/panos_query_rules.py:406:55: undefined-variable Undefined variable 'unicode'
lib/ansible/modules/network/panos/panos_query_rules.py:408:64: undefined-variable Undefined variable 'unicode'
lib/ansible/modules/network/panos/panos_query_rules.py:409:64: undefined-variable Undefined variable 'unicode'
lib/ansible/modules/network/panos/panos_query_rules.py:435:55: undefined-variable Undefined variable 'unicode'
lib/ansible/modules/network/panos/panos_query_rules.py:437:69: undefined-variable Undefined variable 'unicode'
lib/ansible/modules/network/panos/panos_query_rules.py:438:69: undefined-variable Undefined variable 'unicode'

The test ansible-test sanity --test validate-modules failed with the following error:

lib/ansible/modules/network/panos/panos_query_rules.py:0:0: E316 ANSIBLE_METADATA.metadata_version: not a valid value for dictionary value @ data['metadata_version']. Got '1.0'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 16, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2017

@ivanbojer this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 16, 2017
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Aug 17, 2017
@jborean93
Copy link
Contributor

@ivanbojer are you able to rebase your PR by following the docs at http://docs.ansible.com/ansible/latest/dev_guide/developing_rebasing.html

@ansibot
Copy link
Contributor

ansibot commented Aug 17, 2017

@ivanbojer
Copy link
Contributor Author

ready_for_review

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Aug 17, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 17, 2017

@ivanbojer @jtschichold @rnh556

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@jtschichold
Copy link

:shipit:

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 23, 2017
@gundalow
Copy link
Contributor

Rebase needed, and unit test need to be added

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 25, 2017
Ivan Bojer added 3 commits August 28, 2017 14:53
…an be as general or specific as needed. The policy rules are compared against the incoming traffic in sequence, and because the first rule that matches the traffic is applied, the more specific rules must precede the more general ones.
@ivanbojer
Copy link
Contributor Author

Rebase done! We cannot do unit tests in this release as that would need publicly accessible device.

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html shipit This PR is ready to be merged by Core needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 28, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 5, 2017
@ivanbojer ivanbojer closed this Oct 18, 2017
@ivanbojer
Copy link
Contributor Author

Didn't make it for 2.4

@gundalow
Copy link
Contributor

@ivanbojer We can help you get this into Ansible 2.5 if you want to reopen the PR...

@gundalow
Copy link
Contributor

Unit tests don't need a publicly accessible device, you can mock out the data, see other network modules unit tests

@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.4 This issue/PR affects Ansible v2.4 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants