added diff as new keyword #28581
Merged
added diff as new keyword #28581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.4
agaffney
reviewed
Aug 23, 2017
| @@ -242,11 +242,9 @@ class PlayContext(Base): | |||
| _verbosity = FieldAttribute(isa='int', default=0) | |||
| _only_tags = FieldAttribute(isa='set', default=set()) | |||
| _skip_tags = FieldAttribute(isa='set', default=set()) | |||
| _check_mode = FieldAttribute(isa='bool', default=False) | |||
There was a problem hiding this comment.
I assume this is being removed because it's redundant with the one in lib/ansible/playbook/base.py, but should the default be moved to that file?
There was a problem hiding this comment.
yes, was redundant and no, as we check for None in task, which means its 'not set' vs True/False which would override the config and cli options
bcoca
removed
the
needs_triage
ansibot
added
the
needs_revision
bcoca
removed
the
needs_revision
added diff to fake options in ec2_vpc_nat_gateway test
dagwieers
approved these changes
Aug 24, 2017
|
Can we get this merged ASAP ? We need it for doing integration tests in the XML module, so the tests provide proper guidance to why a test failed. |
This was referenced Aug 24, 2017
|
A leap of faith, I trust @bcoca ! |
prasadkatti
pushed a commit
to prasadkatti/ansible
that referenced
this pull request
Oct 1, 2017
added diff to fake options in ec2_vpc_nat_gateway test
ansibot
added
feature
fetzerch
added a commit
to fetzerch/ansible
that referenced
this pull request
Mar 27, 2018
Tasks that deal with secrets may leak sensitive information when running in Check Mode. This change updates the documentation explaining that the diff can be deactivated on task level. The feature was requested in ansible#14860 and got introduced in Ansible 2.4 with ansible#28581.
dharmabumstead
pushed a commit
that referenced
this pull request
Apr 5, 2018
* docs: Document disabling diff on task level Tasks that deal with secrets may leak sensitive information when running in Check Mode. This change updates the documentation explaining that the diff can be deactivated on task level. The feature was requested in #14860 and got introduced in Ansible 2.4 with #28581. * Updated for clarity
nitzmahone
pushed a commit
that referenced
this pull request
Apr 18, 2018
* docs: Document disabling diff on task level Tasks that deal with secrets may leak sensitive information when running in Check Mode. This change updates the documentation explaining that the diff can be deactivated on task level. The feature was requested in #14860 and got introduced in Ansible 2.4 with #28581. * Updated for clarity (cherry picked from commit 9cca9a9)
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
* docs: Document disabling diff on task level Tasks that deal with secrets may leak sensitive information when running in Check Mode. This change updates the documentation explaining that the diff can be deactivated on task level. The feature was requested in ansible#14860 and got introduced in Ansible 2.4 with ansible#28581. * Updated for clarity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
allows to override diff config/cli options in play
ISSUE TYPE
COMPONENT NAME
core
ANSIBLE VERSION