Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACI Tenant EP Retention Policy: Add new module to support managing En… #28642

Merged
merged 3 commits into from
Aug 25, 2017
Merged

ACI Tenant EP Retention Policy: Add new module to support managing En… #28642

merged 3 commits into from
Aug 25, 2017

Conversation

jmcgill298
Copy link
Contributor

…d Point Retention Policies

SUMMARY

Add new module to support managing EndPoint Retention Policies in ACI.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

aci_tenant_ep_retention_policy

ANSIBLE VERSION
2.4
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Aug 25, 2017

cc @dagwieers @schunduri
click here for bot help

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 25, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 25, 2017

The test ansible-test sanity --test validate-modules failed with the following errors:

lib/ansible/modules/network/aci/aci_tenant_ep_retention_policy.py:0:0: E305 DOCUMENTATION.options.bounce_age.type: not a valid value for dictionary value @ data['options']['bounce_age']['type']. Got 'int'
lib/ansible/modules/network/aci/aci_tenant_ep_retention_policy.py:0:0: E305 DOCUMENTATION.options.bounce_trigger.type: not a valid value for dictionary value @ data['options']['bounce_trigger']['type']. Got 'str'
lib/ansible/modules/network/aci/aci_tenant_ep_retention_policy.py:0:0: E305 DOCUMENTATION.options.epr_policy.type: not a valid value for dictionary value @ data['options']['epr_policy']['type']. Got 'str'
lib/ansible/modules/network/aci/aci_tenant_ep_retention_policy.py:0:0: E305 DOCUMENTATION.options.tenant.type: not a valid value for dictionary value @ data['options']['tenant']['type']. Got 'str'
lib/ansible/modules/network/aci/aci_tenant_ep_retention_policy.py:0:0: E316 ANSIBLE_METADATA.metadata_version: not a valid value for dictionary value @ data['metadata_version']. Got '1.0'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 25, 2017
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 25, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 25, 2017

@jmcgill298 @schunduri

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 25, 2017
@dagwieers dagwieers merged commit eaea574 into ansible:devel Aug 25, 2017
@jmcgill298 jmcgill298 deleted the ep_retention branch August 25, 2017 12:16
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Aug 26, 2017
@dagwieers dagwieers added the aci Cisco ACI community label Sep 27, 2017
prasadkatti pushed a commit to prasadkatti/ansible that referenced this pull request Oct 1, 2017
@jmcgill298
ACI Tenant EP Retention Policy: Add new module to support managing En… (
175b30c 
ansible#28642)

* ACI Tenant EP Retention Policy: Add new module to support managing End Point Retention Policies

* Fix docstring errors

* Fix Metadata version
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers approved these changes

Assignees
No one assigned
Labels
aci Cisco ACI community affects_2.4 This issue/PR affects Ansible v2.4 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmcgill298 @ansibot @dagwieers @bcoca