Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aci_config_snapshot: Module to manage ACI config snapshots #28784

Merged
merged 5 commits into from
Aug 30, 2017

Conversation

jmcgill298
Copy link
Contributor

…on the APIC.

SUMMARY

Add new module to support managing ACI config snapshots on the APIC.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

aci_config_snapshot

ANSIBLE VERSION
2.4
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Aug 29, 2017

@ansibot ansibot added affects_2.4 This issue/PR affects Ansible v2.4 c:module_utils/ community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 29, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 29, 2017

The test ansible-test sanity --test ansible-doc --python 2.7 failed with the following error:

Command "ansible-doc aci_aep aci_ap aci_bd aci_bd_subnet aci_bd_to_l3out aci_config_snapshot aci_contract aci_contract_subject aci_contract_subject_to_filter aci_epg aci_epg_monitoring_policy aci_epg_to_contract aci_epg_to_domain aci_filter aci_filter_entry aci_intf_policy_fc aci_intf_policy_l2 aci_intf_policy_lldp aci_intf_policy_mcp aci_intf_policy_port_channel aci_intf_policy_port_security aci_l3out_route_tag_policy aci_rest aci_taboo_contract aci_tenant aci_tenant_action_rule_profile aci_tenant_ep_retention_policy aci_tenant_span_dst_group aci_tenant_span_src_group aci_tenant_span_src_group_to_dst_group aci_vrf" returned exit status 1.
>>> Standard Error
ERROR! module aci_config_snapshot missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 2.6 failed with the following error:

Command "ansible-doc aci_aep aci_ap aci_bd aci_bd_subnet aci_bd_to_l3out aci_config_snapshot aci_contract aci_contract_subject aci_contract_subject_to_filter aci_epg aci_epg_monitoring_policy aci_epg_to_contract aci_epg_to_domain aci_filter aci_filter_entry aci_intf_policy_fc aci_intf_policy_l2 aci_intf_policy_lldp aci_intf_policy_mcp aci_intf_policy_port_channel aci_intf_policy_port_security aci_l3out_route_tag_policy aci_rest aci_taboo_contract aci_tenant aci_tenant_action_rule_profile aci_tenant_ep_retention_policy aci_tenant_span_dst_group aci_tenant_span_src_group aci_tenant_span_src_group_to_dst_group aci_vrf" returned exit status 1.
>>> Standard Error
ERROR! module aci_config_snapshot missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.5 failed with the following error:

Command "ansible-doc aci_aep aci_ap aci_bd aci_bd_subnet aci_bd_to_l3out aci_config_snapshot aci_contract aci_contract_subject aci_contract_subject_to_filter aci_epg aci_epg_monitoring_policy aci_epg_to_contract aci_epg_to_domain aci_filter aci_filter_entry aci_intf_policy_fc aci_intf_policy_l2 aci_intf_policy_lldp aci_intf_policy_mcp aci_intf_policy_port_channel aci_intf_policy_port_security aci_l3out_route_tag_policy aci_rest aci_taboo_contract aci_tenant aci_tenant_action_rule_profile aci_tenant_ep_retention_policy aci_tenant_span_dst_group aci_tenant_span_src_group aci_tenant_span_src_group_to_dst_group aci_vrf" returned exit status 1.
>>> Standard Error
ERROR! module aci_config_snapshot missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test ansible-doc --python 3.6 failed with the following error:

Command "ansible-doc aci_aep aci_ap aci_bd aci_bd_subnet aci_bd_to_l3out aci_config_snapshot aci_contract aci_contract_subject aci_contract_subject_to_filter aci_epg aci_epg_monitoring_policy aci_epg_to_contract aci_epg_to_domain aci_filter aci_filter_entry aci_intf_policy_fc aci_intf_policy_l2 aci_intf_policy_lldp aci_intf_policy_mcp aci_intf_policy_port_channel aci_intf_policy_port_security aci_l3out_route_tag_policy aci_rest aci_taboo_contract aci_tenant aci_tenant_action_rule_profile aci_tenant_ep_retention_policy aci_tenant_span_dst_group aci_tenant_span_src_group aci_tenant_span_src_group_to_dst_group aci_vrf" returned exit status 1.
>>> Standard Error
ERROR! module aci_config_snapshot missing documentation (or could not parse documentation): Parsing produced an empty object.

The test ansible-test sanity --test validate-modules failed with the following error:

lib/ansible/modules/network/aci/aci_config_snapshot.py:61:3: E302 DOCUMENTATION is not valid YAML

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 29, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 29, 2017

The test ansible-test sanity --test ansible-doc --python 2.6 failed with the following error:

Command "ansible-doc aci_aep aci_ap aci_bd aci_bd_subnet aci_bd_to_l3out aci_config_snapshot aci_contract aci_contract_subject aci_contract_subject_to_filter aci_epg aci_epg_monitoring_policy aci_epg_to_contract aci_epg_to_domain aci_filter aci_filter_entry aci_intf_policy_fc aci_intf_policy_l2 aci_intf_policy_lldp aci_intf_policy_mcp aci_intf_policy_port_channel aci_intf_policy_port_security aci_l3out_route_tag_policy aci_rest aci_taboo_contract aci_tenant aci_tenant_action_rule_profile aci_tenant_ep_retention_policy aci_tenant_span_dst_group aci_tenant_span_src_group aci_tenant_span_src_group_to_dst_group aci_vrf" returned exit status 1.
>>> Standard Error
ERROR! module aci_config_snapshot missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 failed with the following error:

Command "ansible-doc aci_aep aci_ap aci_bd aci_bd_subnet aci_bd_to_l3out aci_config_snapshot aci_contract aci_contract_subject aci_contract_subject_to_filter aci_epg aci_epg_monitoring_policy aci_epg_to_contract aci_epg_to_domain aci_filter aci_filter_entry aci_intf_policy_fc aci_intf_policy_l2 aci_intf_policy_lldp aci_intf_policy_mcp aci_intf_policy_port_channel aci_intf_policy_port_security aci_l3out_route_tag_policy aci_rest aci_taboo_contract aci_tenant aci_tenant_action_rule_profile aci_tenant_ep_retention_policy aci_tenant_span_dst_group aci_tenant_span_src_group aci_tenant_span_src_group_to_dst_group aci_vrf" returned exit status 1.
>>> Standard Error
ERROR! module aci_config_snapshot missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 2.7 failed with the following error:

Command "ansible-doc aci_aep aci_ap aci_bd aci_bd_subnet aci_bd_to_l3out aci_config_snapshot aci_contract aci_contract_subject aci_contract_subject_to_filter aci_epg aci_epg_monitoring_policy aci_epg_to_contract aci_epg_to_domain aci_filter aci_filter_entry aci_intf_policy_fc aci_intf_policy_l2 aci_intf_policy_lldp aci_intf_policy_mcp aci_intf_policy_port_channel aci_intf_policy_port_security aci_l3out_route_tag_policy aci_rest aci_taboo_contract aci_tenant aci_tenant_action_rule_profile aci_tenant_ep_retention_policy aci_tenant_span_dst_group aci_tenant_span_src_group aci_tenant_span_src_group_to_dst_group aci_vrf" returned exit status 1.
>>> Standard Error
ERROR! module aci_config_snapshot missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.6 failed with the following error:

Command "ansible-doc aci_aep aci_ap aci_bd aci_bd_subnet aci_bd_to_l3out aci_config_snapshot aci_contract aci_contract_subject aci_contract_subject_to_filter aci_epg aci_epg_monitoring_policy aci_epg_to_contract aci_epg_to_domain aci_filter aci_filter_entry aci_intf_policy_fc aci_intf_policy_l2 aci_intf_policy_lldp aci_intf_policy_mcp aci_intf_policy_port_channel aci_intf_policy_port_security aci_l3out_route_tag_policy aci_rest aci_taboo_contract aci_tenant aci_tenant_action_rule_profile aci_tenant_ep_retention_policy aci_tenant_span_dst_group aci_tenant_span_src_group aci_tenant_span_src_group_to_dst_group aci_vrf" returned exit status 1.
>>> Standard Error
ERROR! module aci_config_snapshot missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test validate-modules failed with the following errors:

lib/ansible/modules/network/aci/aci_config_snapshot.py:0:0: E305 DOCUMENTATION.notes.1: expected str @ data['notes'][1]. Got {'Snapshot files use the following naming structure': 'ce_<config export policy name>-<yyyy>-<mm>-<dd>T<hh>:<mm>:<ss>.<mss>+<hh>:<mm>.'}
lib/ansible/modules/network/aci/aci_config_snapshot.py:0:0: E305 DOCUMENTATION.notes.2: expected str @ data['notes'][2]. Got {'Snapshot objects use the following naming structure': 'run-<yyyy>-<mm>-<dd>T<hh>-<mm>-<ss>.'}
lib/ansible/modules/network/aci/aci_config_snapshot.py:0:0: E305 DOCUMENTATION.options.include_secure.defautl: extra keys not allowed @ data['options']['include_secure']['defautl']. Got 'yes'

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 29, 2017

The test ansible-test sanity --test ansible-doc --python 2.6 failed with the following error:

Command "ansible-doc aci_aep aci_ap aci_bd aci_bd_subnet aci_bd_to_l3out aci_config_snapshot aci_contract aci_contract_subject aci_contract_subject_to_filter aci_epg aci_epg_monitoring_policy aci_epg_to_contract aci_epg_to_domain aci_filter aci_filter_entry aci_intf_policy_fc aci_intf_policy_l2 aci_intf_policy_lldp aci_intf_policy_mcp aci_intf_policy_port_channel aci_intf_policy_port_security aci_l3out_route_tag_policy aci_rest aci_taboo_contract aci_tenant aci_tenant_action_rule_profile aci_tenant_ep_retention_policy aci_tenant_span_dst_group aci_tenant_span_src_group aci_tenant_span_src_group_to_dst_group aci_vrf" returned exit status 1.
>>> Standard Error
ERROR! module aci_config_snapshot missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 2.7 failed with the following error:

Command "ansible-doc aci_aep aci_ap aci_bd aci_bd_subnet aci_bd_to_l3out aci_config_snapshot aci_contract aci_contract_subject aci_contract_subject_to_filter aci_epg aci_epg_monitoring_policy aci_epg_to_contract aci_epg_to_domain aci_filter aci_filter_entry aci_intf_policy_fc aci_intf_policy_l2 aci_intf_policy_lldp aci_intf_policy_mcp aci_intf_policy_port_channel aci_intf_policy_port_security aci_l3out_route_tag_policy aci_rest aci_taboo_contract aci_tenant aci_tenant_action_rule_profile aci_tenant_ep_retention_policy aci_tenant_span_dst_group aci_tenant_span_src_group aci_tenant_span_src_group_to_dst_group aci_vrf" returned exit status 1.
>>> Standard Error
ERROR! module aci_config_snapshot missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 failed with the following error:

Command "ansible-doc aci_aep aci_ap aci_bd aci_bd_subnet aci_bd_to_l3out aci_config_snapshot aci_contract aci_contract_subject aci_contract_subject_to_filter aci_epg aci_epg_monitoring_policy aci_epg_to_contract aci_epg_to_domain aci_filter aci_filter_entry aci_intf_policy_fc aci_intf_policy_l2 aci_intf_policy_lldp aci_intf_policy_mcp aci_intf_policy_port_channel aci_intf_policy_port_security aci_l3out_route_tag_policy aci_rest aci_taboo_contract aci_tenant aci_tenant_action_rule_profile aci_tenant_ep_retention_policy aci_tenant_span_dst_group aci_tenant_span_src_group aci_tenant_span_src_group_to_dst_group aci_vrf" returned exit status 1.
>>> Standard Error
ERROR! module aci_config_snapshot missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 failed with the following error:

Command "ansible-doc aci_aep aci_ap aci_bd aci_bd_subnet aci_bd_to_l3out aci_config_snapshot aci_contract aci_contract_subject aci_contract_subject_to_filter aci_epg aci_epg_monitoring_policy aci_epg_to_contract aci_epg_to_domain aci_filter aci_filter_entry aci_intf_policy_fc aci_intf_policy_l2 aci_intf_policy_lldp aci_intf_policy_mcp aci_intf_policy_port_channel aci_intf_policy_port_security aci_l3out_route_tag_policy aci_rest aci_taboo_contract aci_tenant aci_tenant_action_rule_profile aci_tenant_ep_retention_policy aci_tenant_span_dst_group aci_tenant_span_src_group aci_tenant_span_src_group_to_dst_group aci_vrf" returned exit status 1.
>>> Standard Error
ERROR! module aci_config_snapshot missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test validate-modules failed with the following errors:

lib/ansible/modules/network/aci/aci_config_snapshot.py:0:0: E305 DOCUMENTATION.notes.1: expected str @ data['notes'][1]. Got {'Snapshot files use the following naming structure': 'ce_<config export policy name>-<yyyy>-<mm>-<dd>T<hh>:<mm>:<ss>.<mss>+<hh>:<mm>.'}
lib/ansible/modules/network/aci/aci_config_snapshot.py:0:0: E305 DOCUMENTATION.notes.2: expected str @ data['notes'][2]. Got {'Snapshot objects use the following naming structure': 'run-<yyyy>-<mm>-<dd>T<hh>-<mm>-<ss>.'}

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Aug 29, 2017
@ansibot
Copy link
Contributor

ansibot commented Aug 29, 2017

@jmcgill298 @schunduri

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@jmcgill298
Copy link
Contributor Author

shipit

@dagwieers dagwieers changed the title Snapshot aci_config_snapshot: Module to manage ACI config snapshots Aug 30, 2017
@dagwieers dagwieers merged commit 42db02c into ansible:devel Aug 30, 2017
@jmcgill298 jmcgill298 deleted the snapshot branch August 30, 2017 05:00
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Aug 30, 2017
@dagwieers dagwieers added the aci Cisco ACI community label Sep 27, 2017
prasadkatti pushed a commit to prasadkatti/ansible that referenced this pull request Oct 1, 2017
…8784)

* ACI Config Snapshot: Add module to support managing config snapshots on the APIC.

* add comma back

* Fix docstring errors

* Fix typo

* add quotes for notes section
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aci Cisco ACI community affects_2.4 This issue/PR affects Ansible v2.4 c:module_utils/ cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants