Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix os_image so it works when id is None #29147

Merged
merged 1 commit into from
Sep 9, 2017
Merged

fix os_image so it works when id is None #29147

merged 1 commit into from
Sep 9, 2017

Conversation

jrandall
Copy link
Contributor

@jrandall jrandall commented Sep 8, 2017

SUMMARY

Adds protection to the handling of the id module parameter to the os_image module so that when it is None (which is the default) it is not passed as a keyword argument to shade's create_image function.

Fixes #29145

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

os_image

ANSIBLE VERSION
ansible 2.4.0
  config file = None
  configured module search path = ['/nfs/users/nfs_j/jr17/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /software/hgi/pkglocal/ansible-git-20170906-8f4c8844-hgiextras-992e571d167746f79b7bae07a0db5835/lib/python3.6/site-packages/ansible
  executable location = /software/hgi/pkglocal/ansible-git-20170906-8f4c8844-hgiextras-992e571d167746f79b7bae07a0db5835/bin/ansible
  python version = 3.6.1 (default, May 17 2017, 13:38:25) [GCC 4.9.1]

@ansibot
Copy link
Contributor

ansibot commented Sep 8, 2017

cc @dagnello @emonty @j2sol @juliakreger @rcarrillocruz @Shrews @Thingee
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. openstack python3 support:community This issue/PR relates to code supported by the Ansible community. labels Sep 8, 2017
emonty
emonty approved these changes Sep 9, 2017
View reviewed changes
Copy link
Contributor

@emonty emonty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@emonty emonty merged commit 6e84bad into ansible:devel Sep 9, 2017
Akasurde pushed a commit to Akasurde/ansible that referenced this pull request Sep 10, 2017
@jrandall @Akasurde
fix os_image so it works when id is None (ansible#29147)
59a8cc3 
Fixes ansible#29145
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Sep 11, 2017
@rcarrillocruz rcarrillocruz mentioned this pull request Sep 28, 2017
Closed
abadger pushed a commit that referenced this pull request Sep 28, 2017
@jrandall @abadger
fix os_image so it works when id is None (#29147)
e935907 
Fixes #29145
(cherry picked from commit 6e84bad)
@abadger
Copy link
Contributor

abadger commented Sep 28, 2017

cherry-picked for the 2.4.1 release. Will be in 2.4.1beta2

prasadkatti pushed a commit to prasadkatti/ansible that referenced this pull request Oct 1, 2017
@jrandall
fix os_image so it works when id is None (ansible#29147)
fb08f15 
Fixes ansible#29145
BondAnthony pushed a commit to BondAnthony/ansible that referenced this pull request Oct 5, 2017
@jrandall @BondAnthony
fix os_image so it works when id is None (ansible#29147)
8d76ca8 
Fixes ansible#29145
@pyup-bot pyup-bot mentioned this pull request Jan 1, 2018
Closed
This was referenced Jan 31, 2018
Closed
Closed
Closed
Closed
Closed
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emonty emonty emonty approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. openstack python3 support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

os_image fails when id is None
5 participants
@jrandall @ansibot @abadger @emonty @bcoca