Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numa & fence compare fix #30302

Merged
merged 1 commit into from Oct 4, 2017
Merged

Conversation

machacekondra
Copy link
Contributor

@machacekondra machacekondra commented Sep 13, 2017

SUMMARY

When updating fencing or numa of the cluster we simply pass what user passes, instead of predicting what he really wants.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt_cluster

ANSIBLE VERSION
2.3.1
ADDITIONAL INFORMATION
---
- hosts: localhost
  connection: local
  vars_files:
    - ../vars.yml

  tasks:
  - name: Obtain SSO token
    ovirt_auth:
      url: "{{ url }}"
      username: "{{ username }}"
      password: "{{ password }}"
      insecure: "{{ insecure }}"

  - name: Create cluster
    ovirt_cluster:
      auth: "{{ ovirt_auth }}"
      name: golden_env_mixed_1
      ksm: false
      ksm_numa: false
      fence_enabled: false
      fence_skip_if_sd_active: false
      fence_skip_if_connectivity_broken: true

@machacekondra
Copy link
Contributor Author

@mwperina @pkubica @ryansb shipit

Please also cherry-pick to Ansible 2.4, if possible.

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 13, 2017
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Sep 14, 2017
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 23, 2017
@mwperina
Copy link
Contributor

mwperina commented Oct 4, 2017

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core automerge This PR was automatically merged by ansibot. and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 4, 2017
@ansibot ansibot merged commit 5e3177e into ansible:devel Oct 4, 2017
BondAnthony pushed a commit to BondAnthony/ansible that referenced this pull request Oct 5, 2017
@roolebo
Copy link
Contributor

roolebo commented Oct 26, 2017

ovirt_cluster module doesn't work without a part of the commit unless mac_pool is configured.

Please cherry-pick it to 2.4

@ansibot ansibot added the bug This issue/PR relates to a bug. label Mar 6, 2018
@dagwieers dagwieers added the ovirt oVirt and RHV community label Feb 20, 2019
@dagwieers dagwieers removed virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 28, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants