Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EC2_LC - Fix for unrequired parameter instance_profile_name #30573

Merged
merged 1 commit into from
Sep 20, 2017
Merged

EC2_LC - Fix for unrequired parameter instance_profile_name #30573

merged 1 commit into from
Sep 20, 2017

Conversation

wilvk
Copy link
Contributor

@wilvk wilvk commented Sep 19, 2017

SUMMARY

This PR is a fix for issue #30268.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/ec2_lc.yml

ANSIBLE VERSION
ansible 2.5.0 (ec2_lc_fix 4acdd30769) last updated 2017/09/20 06:00:42 (GMT +1100)
  config file = None
  configured module search path = [u'/Users/willvk/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/willvk/Source/gits/ansibles/ansible/lib/ansible
  executable location = /Users/willvk/Source/gits/ansibles/ansible/bin/ansible
  python version = 2.7.10 (default, Feb  7 2017, 00:08:15) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.34)]

@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2017

cc @garethr
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 aws bugfix_pull_request cloud committer_review In order to be merged, this PR must follow the certified review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:certified This issue/PR relates to certified code. labels Sep 19, 2017
@willthames willthames merged commit 9242684 into ansible:devel Sep 20, 2017
@willthames
Copy link
Contributor

Thanks @wilvk for the fix, and also @gurumaia for an excellent report in #30268 that made reviewing this very easy.

@wilvk wilvk deleted the ec2_lc_fix branch September 20, 2017 05:12
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Sep 20, 2017
@abadger
Copy link
Contributor

abadger commented Sep 21, 2017

cherry-picked to stable-2.4 for 2.4.1 release.

@pyup-bot pyup-bot mentioned this pull request Jan 1, 2018
Closed
This was referenced Jan 31, 2018
Closed
Closed
Closed
Closed
Closed
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 aws bug This issue/PR relates to a bug. cloud committer_review In order to be merged, this PR must follow the certified review workflow. module This issue/PR relates to a module. support:certified This issue/PR relates to certified code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wilvk @ansibot @willthames @abadger @bcoca