Move away from eval #30650
Merged
Move away from eval #30650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.5
abadger
reviewed
Sep 20, 2017
lib/ansible/config/base.yml
Outdated
| @@ -1255,7 +1255,7 @@ INVENTORY_ENABLED: | |||
| type: list | |||
| INVENTORY_IGNORE_EXTS: | |||
| name: Inventory ignore extensions | |||
| default: eval(BLACKLIST_EXTS + ( '~', '.orig', '.ini', '.cfg', '.retry')) | |||
| default: "{{(BLACKLIST_EXTS + ( '~', '.orig', '.ini', '.cfg', '.retry'))|list}}" | |||
There was a problem hiding this comment.
Note: piping to list probably isn't needed (it's what literal_eval will do)
bcoca
removed
the
needs_triage
bcoca
force-pushed
the
move_away_from_eval
branch
from
57192d4
to
8e94348
Compare
|
shipit |
|
Do we want to cherry-pick this so that 2.4.x has jinja2 in the config syntax? |
|
Cherry-picked for 2.4.1. |
This was referenced Jan 31, 2018
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
use templating + literal_eval as a 'nicer' dynamic default config
ISSUE TYPE
COMPONENT NAME
configuration
ANSIBLE VERSION