Changed 'plugins/json_query.py' to use jebabin's solution to issue #27299

[bdlamprecht]

SUMMARY

Submitting this PR as a solution for Issue #27299 .

This change uses the python library ast to resolve some issues that arise from using certain query strings including starts_with, contains, and others.

This solution was from @jebabin . I'm submitting the PR because even though I don't understand the fix completely, it seems a simple enough of a fix to include future releases of Ansible (possibly even back-porting to other releases of Ansible 2.4).

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

json_query

ANSIBLE VERSION

ansible --version
ansible 2.5.0 (devel 140ea7f5ff) last updated 2017/09/20 13:14:52 (GMT -600)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/usr/share/my_modules']
  ansible python module location = /home/bl839s/ansible/lib/ansible
  executable location = /home/bl839s/ansible/bin/ansible
  python version = 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609]

ADDITIONAL INFORMATION

See Issue #27299 for details.

Before:

PLAY [json_query testing] ****************************************************************************

TASK [debug] *****************************************************************************************
fatal: [localhost]: FAILED! => {"msg": "JMESPathError in json_query filter plugin:\nIn function contains(), invalid type for value: irb.1111, expected one of: ['array', 'string'], received: \"unknown\""}

PLAY RECAP *******************************************************************************************
localhost                  : ok=0    changed=0    unreachable=0    failed=1

After:

PLAY [json_query testing] ****************************************************************************

TASK [debug] *****************************************************************************************
ok: [localhost] => (item={u'interface': u'irb.1111', u'address': u'10.0.1.1/29'}) => {
    "item": {
        "address": "10.0.1.1/29",
        "interface": "irb.1111"
    }
}
ok: [localhost] => (item={u'interface': u'irb.1114', u'address': u'10.0.2.1/29'}) => {
    "item": {
        "address": "10.0.2.1/29",
        "interface": "irb.1114"
    }
}
ok: [localhost] => (item={u'interface': u'irb.1114', u'address': u'fe80::b/112'}) => {
    "item": {
        "address": "fe80::b/112",
        "interface": "irb.1114"
    }
}

PLAY RECAP *******************************************************************************************
localhost                  : ok=1    changed=0    unreachable=0    failed=0

[ansibot]

@bdlamprecht This PR contains @ mentions in at least one commit message. Those mentions can cause cascading notifications through GitHub and need to be removed. Please squash or amend your commits to remove the mentions.

click here for bot help

[bdlamprecht]

Fixed the @ issue mentioned in the commit message by ansibot above.

[ansibot]

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/plugins/filter/json_query.py:32:1: E303 too many blank lines (3)
lib/ansible/plugins/filter/json_query.py:51:1: E302 expected 2 blank lines, found 1

click here for bot help

[ansibot]

The test ansible-test sanity --test pep8 [?] failed with the following error:

lib/ansible/plugins/filter/json_query.py:50:1: E302 expected 2 blank lines, found 1

click here for bot help

[gundalow]

If we want, this it will needs tests

[bdlamprecht]

At this point, I don't care what happens with the PR seeing as it is so old.
I don't have the time to write the tests, so unless someone else is willing to, feel free to close out this PR.

[ansibot]

@bdlamprecht Your branch does not contain a shippable.yml file. Please rebase your branch to trigger running of current tests.

click here for bot help

[gundalow]

Given #30653 (comment) closing.