Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python3 and nonascii handling in inventory plugins #30666

Merged
merged 1 commit into from
Sep 21, 2017
Merged

Fix python3 and nonascii handling in inventory plugins #30666

merged 1 commit into from
Sep 21, 2017

Conversation

abadger
Copy link
Contributor

@abadger abadger commented Sep 21, 2017

Fixes #30663

SUMMARY
  • Fixes one known problem fixed where we compared a byte string with text strings (which is always false on python3).
  • Also fixes places that would likely fail on python2 with nonascii strings
  • Fixes some unreported problems comparing byte strings with text strings.
  • Fixes loading the virtualbox cache with a mangled entry.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

various inventory plugins

ANSIBLE VERSION
devel 2.4

@abadger abadger force-pushed the inventory-py3-and-nonascii-fixes branch from f3c5224 to aa8d974 Compare September 21, 2017 00:12
@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request needs_triage Needs a first human triage before being processed. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 21, 2017
@bcoca
Copy link
Member

bcoca commented Sep 21, 2017

shipit

@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Sep 21, 2017
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 21, 2017
@abadger abadger merged commit 72bdf7a into ansible:devel Sep 21, 2017
@abadger abadger deleted the inventory-py3-and-nonascii-fixes branch September 21, 2017 02:39
@abadger
Copy link
Contributor Author

abadger commented Sep 21, 2017

Merged and cherrypicked for 2.4.1.

@pyup-bot pyup-bot mentioned this pull request Jan 1, 2018
Closed
This was referenced Jan 31, 2018
Closed
Closed
Closed
Closed
Closed
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
Inventory revamp
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yaml inventory plugin fails with Py3
3 participants
@abadger @bcoca @ansibot