Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #31056 - nxos_portchannel idempotence failure on N1 images #31057

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Fixes #31056 - nxos_portchannel idempotence failure on N1 images #31057

merged 1 commit into from
Oct 13, 2017

Conversation

rahushen
Copy link
Contributor

SUMMARY

Output of show port-channel summary | json returns group as int as compared to a string on other platforms. This causes idempotence issues on N1 images. The fix is to check for both string and int equality.

Fixes #31056

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • nxos_portchannel
ANSIBLE VERSION
ansible 2.4.0.0 (detached HEAD d14467b029) last updated 2017/09/28 11:09:55 (GMT -400)
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]

@ansibot
Copy link
Contributor

ansibot commented Sep 28, 2017

cc @GGabriele @jedelman8 @mikewiebe @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Sep 28, 2017
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Sep 28, 2017
mikewiebe
mikewiebe reviewed Sep 28, 2017
View reviewed changes
lib/ansible/modules/network/nxos/nxos_portchannel.py
@@ -203,6 +203,8 @@ def get_portchannel(module, netcfg=None):
for pc in pc_table:
if pc['group'] == module.params['group']:
portchannel_table = pc
elif module.params['group'].isdigit() and pc['group'] == int(module.params['group']):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this change against all nxos platforms? Just want to make sure since this area has been historically prone to idempotence issues that were fixed in 2.4.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikewiebe ... I've tested our matrix and it passed the tests. I will rerun and confirm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahushen Did you retest this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikewiebe @trishnaguha Yes, retested and it passed the tests.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 7, 2017
@trishnaguha trishnaguha self-assigned this Oct 11, 2017
@trishnaguha trishnaguha added the needs_info This issue requires further information. Please answer any outstanding questions. label Oct 11, 2017
@ansibot ansibot removed the core_review In order to be merged, this PR must follow the core review workflow. label Oct 11, 2017
@rahushen
Copy link
Contributor Author

@trishnaguha ... this also needs to be cherry-picked to 2.4.1

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_info This issue requires further information. Please answer any outstanding questions. labels Oct 12, 2017
@trishnaguha trishnaguha merged commit 046d430 into ansible:devel Oct 13, 2017
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Oct 13, 2017
@rahushen @trishnaguha
Fixes ansible#31056 (ansible#31057)
2c6cbd2 
(cherry picked from commit 046d430)
BondAnthony pushed a commit to BondAnthony/ansible that referenced this pull request Oct 14, 2017
@rahushen @BondAnthony
Fixes ansible#31056 (ansible#31057)
9b2382f
mtb-xt pushed a commit to mtb-xt/ansible that referenced this pull request Oct 15, 2017
@rahushen
Fixes ansible#31056 (ansible#31057)
fd38714
@trishnaguha
Copy link
Member

This will be out with 2.4.2 release as 2.4.1 rc1 is already out.

abadger pushed a commit that referenced this pull request Oct 26, 2017
@rahushen @abadger
Fixes #31056 (#31057)
a69f93f 
(cherry picked from commit 046d430)
@rahushen rahushen deleted the nxos_portchannel branch December 5, 2017 18:25
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added nxos Cisco NXOS community cisco Cisco technologies labels Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikewiebe mikewiebe mikewiebe left review comments

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community owner_pr This PR is made by the module's maintainer. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nxos_portchannel : module not idempotent for N1 images
6 participants
@rahushen @ansibot @trishnaguha @mikewiebe @dagwieers @samdoran