Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #31090. network parse_cli filter plugin doesn't use single match when using start/end blocks #31092

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Fixes #31090. network parse_cli filter plugin doesn't use single match when using start/end blocks #31092

merged 1 commit into from
Oct 27, 2017

Conversation

skamithi
Copy link
Contributor

SUMMARY

Fixes #31090. Moves the creation of a new block from the match_start section to the match_end section. This problem only occurs if one uses the start_block and end_block feature.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

filter_plugins/network.py

ANSIBLE VERSION
ansible 2.4.0
  config file = None
  configured module search path = [u'/home/skamithi/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/skamithi/fix_parser/local/lib/python2.7/site-packages/ansible
  executable location = /home/skamithi/fix_parser/bin/ansible
  python version = 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609]

@linuxsimba
Fixes #31090. In network parse_cli filter plugin, this change moves t…
a226435 
…he creation of a

new match(block). It previously only occurred if a new match occurred,
but suggest it should occur when an end of a block match is found.
@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request needs_triage Needs a first human triage before being processed. plugins/filter support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 29, 2017
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Sep 29, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 7, 2017
@ansibot
Copy link
Contributor

ansibot commented Oct 15, 2017

cc @Qalthos @ganeshrn @gundalow @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added the networking Network category label Oct 15, 2017
@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2017

cc @kedarX
click here for bot help

@gundalow
Copy link
Contributor

We will need tests adding for this

ganeshrn
ganeshrn approved these changes Oct 27, 2017
View reviewed changes
Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ganeshrn
Copy link
Member

Currently, there are no unit test cases available for filter/network.py.
I am adding the unit test case for this file as part of PR #31562.

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 27, 2017
@ganeshrn
Copy link
Member

@skamithi Thank you.

@ganeshrn ganeshrn merged commit 7553c42 into ansible:devel Oct 27, 2017
ganeshrn pushed a commit to ganeshrn/ansible that referenced this pull request Nov 1, 2017
@skamithi @ganeshrn
Fixes ansible#31090. In network parse_cli filter plugin, this change …
7e03ad1 
…moves the creation of a (ansible#31092)

new match(block). It previously only occurred if a new match occurred,
but suggest it should occur when an end of a block match is found.
(cherry picked from commit 7553c42)

Update CHANGELOG
@ganeshrn ganeshrn mentioned this pull request Nov 1, 2017
Merged
ganeshrn added a commit that referenced this pull request Nov 1, 2017
@ganeshrn
Fixes #31090. In network parse_cli filter plugin, this change moves t…
5bbf70a 
…he creation of a (#31092) (#32458)

new match(block). It previously only occurred if a new match occurred,
but suggest it should occur when an end of a block match is found.
(cherry picked from commit 7553c42)

Update CHANGELOG
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

Assignees

@ganeshrn ganeshrn

Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. networking Network category plugins/filter support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

network parse_cli filter - single match is not caught when using start_block and end_block feature
6 participants
@skamithi @ansibot @gundalow @ganeshrn @s-hertel @linuxsimba