Fixes # if include_vars dir is file instead of directory code breaks

[shuklaabhi]

SUMMARY

Bug fix for include_var plugin

• name: 'Include all variables'
  include_vars:
  dir: 'vars/webserver'
  extensions: ['yml']

Include_var plugin expects a directory in dir parameter. However if its a file instead of directory the code breaks.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

include_vars plugin

ANSIBLE VERSION

ansible 2.4.0.0
  config file = None
  configured module search path = ['/home/xtreme/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/xtreme/helper-venv/lib/python3.6/site-packages/ansible
  executable location = /home/xtreme/helper-venv/bin/ansible
  python version = 3.6.2 (default, Aug 12 2017, 21:28:03) [GCC 5.4.0 20160609]

ADDITIONAL INFORMATION

If the dir param is a file instead of a directory for the include_vars plugin the code breaks with following error.

Before:
  File "/home/xtreme/helper-venv/lib/python3.6/site-packages/ansible/executor/task_executor.py", line 125, in run
    res = self._execute()
  File "/home/xtreme/helper-venv/lib/python3.6/site-packages/ansible/executor/task_executor.py", line 528, in _execute
    result = self._handler.run(task_vars=variables)
  File "/home/xtreme/helper-venv/lib/python3.6/site-packages/ansible/plugins/action/include_vars.py", line 142, in run
    if failed:
UnboundLocalError: local variable 'failed' referenced before assignment

After change it gives you a message that given path is not a directory.

TASK [webserver : Include all variables] *************************************************************************************************************************
task path: /home/xtreme/workspace/gearbox/gearbox.git/ops/deploy/roles/webserver/tasks/main.yml:2
fatal: [54.210.139.47]: FAILED! => {
"ansible_facts": {},
"ansible_included_var_files": [],
"changed": false,
"failed": true,
"message": "vars/webserver is not a directory"
}

[bcoca]

rebuild_merge

[abadger]

cherrypicked for 2.4.1beta2