Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nxos_banner removal idempotence issue in N1 images #31259

Merged
merged 2 commits into from
Oct 11, 2017
Merged

Fix nxos_banner removal idempotence issue in N1 images #31259

merged 2 commits into from
Oct 11, 2017

Conversation

rahushen
Copy link
Contributor

@rahushen rahushen commented Oct 3, 2017

SUMMARY

Default banner for N1 image is different and hence idempotency check was failing.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • nxos_banner
ANSIBLE VERSION
ansible 2.4.0.0 (detached HEAD d14467b029) last updated 2017/10/02 15:33:27 (GMT -400)
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]

@ansibot
Copy link
Contributor

ansibot commented Oct 3, 2017

cc @GGabriele @jedelman8 @mikewiebe @privateip @rcarrillocruz @TrishNag @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Oct 3, 2017
@ansibot
Copy link
Contributor

ansibot commented Oct 3, 2017

The test ansible-test sanity --test pep8 [?] failed with the following error:

lib/ansible/modules/network/nxos/nxos_banner.py:95:1: E302 expected 2 blank lines, found 1

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 3, 2017
@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Oct 3, 2017
@ansibot ansibot removed the owner_pr This PR is made by the module's maintainer. label Oct 3, 2017
trishnaguha
trishnaguha reviewed Oct 4, 2017
View reviewed changes
Copy link
Member

@trishnaguha trishnaguha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the pep8 issue and this is good to go.
Thanks for the PR.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. owner_pr This PR is made by the module's maintainer. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 5, 2017
@trishnaguha trishnaguha merged commit 025386c into ansible:devel Oct 11, 2017
@rahushen
Copy link
Contributor Author

@trishnaguha ... this also needs to be cherry-picked to 2.4.1

trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Oct 13, 2017
@rahushen @trishnaguha
Fix nxos_banner removal idempotence issue in N1 images (ansible#31259)
f73b146 
* Fix nxos_banner removal idempotence issue in N1 images

* handle pep8 error

(cherry picked from commit 025386c)
BondAnthony pushed a commit to BondAnthony/ansible that referenced this pull request Oct 14, 2017
@rahushen @BondAnthony
Fix nxos_banner removal idempotence issue in N1 images (ansible#31259)
484c423 
* Fix nxos_banner removal idempotence issue in N1 images

* handle pep8 error
mtb-xt pushed a commit to mtb-xt/ansible that referenced this pull request Oct 15, 2017
@rahushen
Fix nxos_banner removal idempotence issue in N1 images (ansible#31259)
9fd4fb3 
* Fix nxos_banner removal idempotence issue in N1 images

* handle pep8 error
@trishnaguha
Copy link
Member

This will be out with 2.4.2 release as 2.4.1 rc1 is already out.

@rahushen
Copy link
Contributor Author

@trishnaguha Is there a timeline for 2.4.2 ? Will there be a rc2 for 2.4.1 ?

@trishnaguha
Copy link
Member

@rahushen 2.4.2 is next month.

abadger pushed a commit that referenced this pull request Oct 26, 2017
@rahushen @abadger
Fix nxos_banner removal idempotence issue in N1 images (#31259)
f2e8339 
* Fix nxos_banner removal idempotence issue in N1 images

* handle pep8 error

(cherry picked from commit 025386c)
@rahushen rahushen deleted the nxos_banner branch December 5, 2017 18:24
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added nxos Cisco NXOS community cisco Cisco technologies labels Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rahushen @ansibot @trishnaguha @dagwieers @ryansb