Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nxos_acl: change ports to non well known ports and drop time_range for N1 #31261

Merged
merged 1 commit into from
Oct 11, 2017
Merged

nxos_acl: change ports to non well known ports and drop time_range for N1 #31261

merged 1 commit into from
Oct 11, 2017

Conversation

rahushen
Copy link
Contributor

@rahushen rahushen commented Oct 3, 2017

SUMMARY

N1 images don't support time_range property and have a weird behavior for port numbers. Changing tests to use non well known ports.

ISSUE TYPE
  • IT Pull Request
COMPONENT NAME
  • nxos_acl
ANSIBLE VERSION
ansible 2.4.0.0 (detached HEAD d14467b029) last updated 2017/10/03 15:40:50 (GMT -400)
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]

@ansibot
Copy link
Contributor

ansibot commented Oct 3, 2017

cc @GGabriele @jedelman8 @mikewiebe @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 3, 2017
@gundalow gundalow changed the title change ports to non well known ports and drop time_range for N1 nxos_acl: change ports to non well known ports and drop time_range for N1 Oct 4, 2017
@gundalow gundalow added networking Network category and removed needs_triage Needs a first human triage before being processed. labels Oct 4, 2017
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 4, 2017
@trishnaguha trishnaguha self-assigned this Oct 11, 2017
@trishnaguha trishnaguha merged commit c976ac7 into ansible:devel Oct 11, 2017
@rahushen
Copy link
Contributor Author

@trishnaguha ... this also needs to be cherry-picked to 2.4.1

trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Oct 13, 2017
@rahushen @trishnaguha
change ports to non well known ports and drop time_range for N1 (ansi…
bbf5b4f 
…ble#31261)

(cherry picked from commit c976ac7)
BondAnthony pushed a commit to BondAnthony/ansible that referenced this pull request Oct 14, 2017
@rahushen @BondAnthony
change ports to non well known ports and drop time_range for N1 (ansi…
e7b45ca 
…ble#31261)
mtb-xt pushed a commit to mtb-xt/ansible that referenced this pull request Oct 15, 2017
@rahushen
change ports to non well known ports and drop time_range for N1 (ansi…
886624e 
…ble#31261)
@trishnaguha
Copy link
Member

This will be out with 2.4.2 release as 2.4.1 rc1 is already out.

abadger pushed a commit that referenced this pull request Oct 26, 2017
@rahushen @abadger
change ports to non well known ports and drop time_range for N1 (#31261)
0aa015d 
(cherry picked from commit c976ac7)
@rahushen rahushen deleted the nxos_acl_tf branch December 5, 2017 18:24
@dagwieers dagwieers added nxos Cisco NXOS community cisco Cisco technologies labels Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Awaiting requested review from Qalthos

Assignees

@trishnaguha trishnaguha

Labels
affects_2.5 This issue/PR affects Ansible v2.5 cisco Cisco technologies networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rahushen @ansibot @trishnaguha @dagwieers @gundalow